search

subgraph / roflcoptor

Tor Control Port Filter and State Tracker Daemon
BSD 3-Clause "New" or "Revised" License
25 stars 8 forks source link

write more unit tests #19

Closed david415 closed 8 years ago

david415 commented 8 years ago

dev branch here: https://github.com/david415/roflcoptor/tree/add_unit_tests.1

please review

david415 commented 8 years ago

ok i merged my unit test into master here https://github.com/subgraph/roflcoptor/commit/4c33416c2c1addae140c97ba5f7b15e751cfb9f9

but we should write additional tests.

david415 commented 8 years ago

i recently added more tests... specifically for our listener service code (currently names MortalListener) which ensures that all of a listeners connections can be closed (and if they be unix domain sockets then unlinked as well).

maybe we should examine the code coverage heat map to help us decide which tests to write next?

coverage: 54.7% of statements

david415 commented 8 years ago

coverage: 80.1% of statements