subgraph / roflcoptor

Tor Control Port Filter and State Tracker Daemon
BSD 3-Clause "New" or "Revised" License
25 stars 8 forks source link

remove dependency on procsnitch #56

Closed adrelanos closed 7 years ago

adrelanos commented 8 years ago

Is the procsnitch dependency important or could it please be removed?

david415 commented 8 years ago

no we should not remove procsnitchd as a dependency because it's a privilege separation daemon which allows roflcoptor run as an unprivileged user. i could see an argument for making a build tag to optionally build roflcoptor without procsnitchd so that all the listeners have a configured policy attached to them; does that sound like a helpful alternative?

adrelanos commented 8 years ago

Yes.

david415 commented 8 years ago

ok we decided to remove procsnitchd as a dependency since we don't really need it to select a filter policy because we can use the listener as the only means of selecting a policy. Each listener has a policy assigned to it.

david415 commented 8 years ago

work in progress -> https://github.com/david415/roflcoptor/tree/56.remove_procsnitch.0

david415 commented 8 years ago

i've tested roflcoptor without procsnitchd and it works... but i need others to test it as well to make sure!

@dma https://github.com/subgraph/roflcoptor/pull/60