subgraph / roflcoptor

Tor Control Port Filter and State Tracker Daemon
BSD 3-Clause "New" or "Revised" License
25 stars 8 forks source link

Onionshare produces many variations of control port requests that mean the same thing #59

Open dma opened 8 years ago

dma commented 8 years ago

TIL that Onionshare assembles Tor control port request strings at run-time that can (and do) vary as strings even when they are identical requests as far as Tor is concerned.

This leads to dumb workarounds like:

https://github.com/subgraph/roflcoptor/commit/b2063d103b25a1f728476bb7307e1b23db6be7ca

which would lead to, conceivably, some absurd policies in the future..

Two ideas to address this:

Roflcoptor supports regular expressions in policies, we can make policies that use them to evaluate these kinds of matches, or make Roflcoptor smarter about the Tor control port protocol so that it can normalize a request to some canonical representation for filter validation. Or we can just write stupid looking filter policies if it's not a real problem.