subh05sus / ThalaForReason

Thala For Reason is a fun project inspired by the legendary MS Dhoni, also known as "Thala." The project allows users to check if they are Thala in a humorous way, following the famous meme trend.
https://thala.subhadip.me/
MIT License
4 stars 16 forks source link

Add Field Validation in Backend #3

Closed mathanraj0601 closed 10 months ago

mathanraj0601 commented 10 months ago

Add Field Validation in the Backend

Description

Plan

mathanraj0601 commented 10 months ago

I am excited to work on this @subh05sus Can you assign me this for SWOC24?

SadanandMiskin commented 10 months ago

@mathanraj0601 what validation you mean? Is it only checking whether the email is correct? or is it validation of data from database?

sanketshinde3001 commented 10 months ago

hello , i have work on this project of my own . I have added multiple varification to check that input is related to dhoni or thala . so assign me this issue , i'll make it perfect

mathanraj0601 commented 10 months ago
const question = req.body.query;

HI @SadanandMiskin, There is no check for the body. query in the backend server.js so it can be empty if we hit API directly,

subh05sus commented 10 months ago

@sanketshinde3001 you need to raise an issue first to start working on that project, else your marks won't be added sadly

sanketshinde3001 commented 10 months ago

@subh05sus yes At that moment i don't know about it But later i raise issue for that... You can check it out

mathanraj0601 commented 10 months ago

That great @subh05sus . Update you with a PR soon