search

subhadeeproy3902 / BloxAI

Craft flowcharts and diagrams effortlessly with Blox AI. Seamlessly create visuals and rich documentation, collaborate with your team, and enjoy secure sharing. Start visualizing your ideas today!
https://blox-ai.vercel.app
MIT License
51 stars 60 forks source link

refactor: replace redundant <a> tag with <span> #317

Closed awesohame closed 1 week ago

awesohame commented 1 week ago

Related Issue

Removed potentially dangerous tag that leads to a 404 page.

Description

Replace potentially dangerous tags with safer alternatives. I raised an issue earlier that was assigned to me but was closed before i could fix it. The PR which was merged had potentially dangerous tags.

Type of PR

  • [X] Bug fix

Checklist:

  • [X] I have performed a self-review of my code
  • [X] I have read and followed the Contribution Guidelines.
  • [X] I have tested the changes thoroughly before submitting this pull request.
  • [X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [X] I have commented my code, particularly in hard-to-understand areas.
vercel[bot] commented 1 week ago

@awesohame is attempting to deploy a commit to the subhadeep3902's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot] commented 1 week ago

Welcome to Blox AI! 🎉 Thank you for submitting your pull request. We're excited to review it! 🚀 If you haven't already, be sure to check out our site to learn more about how Blox AI makes crafting flowcharts and diagrams a breeze, and how you can get explanations from the top Google Gemini model about your creations. Start visualizing your ideas today! Visit Blox AI for more information.

subhadeeproy3902 commented 1 week ago

@awesohame what change have u even done?

awesohame commented 1 week ago

@subhadeeproy3902 I have changed anchor tag to span as it is not needed. Anchor tags mess with Next.js's client-side routing. This PR fixes an overlooked problem in an issue which was assigned to me.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blox-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 9:21am