search

subhamayd2 / day_night_time_picker

A day night time picker for Flutter. Beautiful day and night animation with Sun and Moon assets.
https://pub.dev/packages/day_night_time_picker
Apache License 2.0
93 stars 83 forks source link

Adding new optional parameter to display or hide banner. #114

Closed Judreu closed 1 year ago

Judreu commented 1 year ago

To avoid an instability, by default the banner is displayed New parameter name is: bool displayBanner

Judreu commented 1 year ago

Closed by misunderstanding of GitHub sorry, the pull request is sill available !

subhamayd2 commented 1 year ago

The point of this package is the Day Night animation. You want to hide that itself? :(

Judreu commented 1 year ago

Hello, in some cases, I need to gain space to make all widgets fit in the available space. To be homogeneous, I just want to display the animation only where there is enough space.

subhamayd2 commented 1 year ago

Oh okay. Sounds good. :)

subhamayd2 commented 1 year ago

@all-contributors please add @AnlienApp for code

allcontributors[bot] commented 1 year ago

@subhamayd2

I've put up a pull request to add @AnlienApp! :tada:

Judreu commented 1 year ago

I published new modification to fit your recommendation Hope it will be fine with that

Judreu commented 1 year ago

Hello, i don't know if I have to do something more, this is my first pull request for another project.

subhamayd2 commented 1 year ago

This looks good. Thanks for the help ❤️

subhamayd2 commented 1 year ago

Hey, I noticed we already had a prob called displayHeader, which basically hides the banner. I think that's what you want. I should have checked the code first before merging this, but anyway, I have reverted this.