search

subhamayd2 / day_night_time_picker

A day night time picker for Flutter. Beautiful day and night animation with Sun and Moon assets.
https://pub.dev/packages/day_night_time_picker
Apache License 2.0
93 stars 83 forks source link

Please increment major revision when introducing a breaking change #97

Closed jonbhanson closed 1 year ago

jonbhanson commented 1 year ago

Hello and thanks for your work on this package!

I just wanted to give some constructive feedback. When you introduce a breaking change, such as those included in version 1.2.0, Semantic Versioning item 9 instructs that you should change the major version number.

In my case, I upgraded to version 1.2 expecting no breaking changes since it was not a major revision, and was surprised by the breaking changes.

Once again, I appreciate the work you've put into this,

Signed, Another package developer.

subhamayd2 commented 1 year ago

Thank you for that feedback. It was a silly mistake on my part - I should have been more careful about this. I will definitely keep this in mind from next time.

maltemedocs commented 1 year ago

Thank you. I just had a look here whether this got already discussed. This package is way too nice for issues like this, I really appreciate this reaction.