timothy1ee
commented
10 years ago Good job! The point of this homework was to explore some challenges involved in developing a richer MVC client. You should aim for a higher level of polish, you'll find that forces you to learn more of the nooks and crannies of iOS.
- Your profile images are weird because you're using the UITableViewCell's builtin imageView when you should add your own.
- None of your Auto Layout constraints are correct.
- You should be using UILabels, not UITextViews. Why should you be able to tap in a tweet and bring up the keyboard?
- Tweet compose should be modal, not navigation.
- On the detail view, the images are stretched.
Below is the checklist I went through when reviewing your application.
- Did you create a custom Tweet cell and properly set up Auto Layout constraints?
- Did you augment the User and Tweet model with the required properties?
- Does tapping on a Tweet take you to a detailed Tweet view?
- Is the detailed Tweet view styled like the mock?
- Did you add both standard and retina (@2x) image assets? A new feature of XCode is to use the Images.xcassets, it makes it easier to handle the standard and retina assets. If you only included standard assets, it will be scaled for retina displays which makes them a little blurry.
- Does tapping on retweet and favorite increment the retweet and favorite count? If I go back to the index and tap on the same tweet again, is the tweet still marked as retweeted or favorited with the correct count?
- Does the compose view restrict the number of Twitter characters?
"/cc @timothy1ee"