search

subhendukundu / worker-auth-providers

worker-auth-providers is an open-source providers to make authentication easy with workers. Very lightweight script which doesn't need a lot of dependencies. Plug it with any framework or template of workers.
https://authc1.com
279 stars 29 forks source link

Redirect Options inconsistency with facebook #30

Closed OultimoCoder closed 10 months ago

OultimoCoder commented 1 year ago

Every other redirect options looks like:

  const location = await github.redirect({
    options: {
    }
  })

Facebooks looks like:

  const location = await facebook.redirect({

  })

Can we make this consistent please

subhendukundu commented 1 year ago

Great catch, sure!

OultimoCoder commented 1 year ago

Picked it up when upgrading and running integration tests here (I have tests for all the providers minus apple rn):

https://github.com/OultimoCoder/cloudflare-planetscale-hono-boilerplate