subhh / libconnect

Diese TYPO3-Extension ist von Avonis im Auftrag der Staats- und Universitaetsbibliothek Hamburg entwickelt worden. Mit ihr lassen sich Ergebnisse aus den Informationssystemen EZB und DBIS der Universitaet Regensburg direkt in das TYPO3-System einbinden.
GNU General Public License v2.0
8 stars 8 forks source link

ZDB Linked Data Service: Suspicious Multiple Requests #25

Open thoffma opened 2 years ago

thoffma commented 2 years ago

Hi! We (German National Library) were alerted by our system that we recieve unusual many (multiple) requests from different ip adresses who are all using the agent "TYPO3". After some mail contact with different institutions we suspect the modul libconnect to be the troublemaker.

The requests looks like this:

"GET /data/1468190-0.rdf HTTP/1.1" 200 5758 " "GET /data/1468190-0.rdf HTTP/1.1" 200 5758 " "GET /data/2220742-9.rdf HTTP/1.1" 200 5198 " "GET /data/2220742-9.rdf HTTP/1.1" 200 5198 "

and so on... We can not say since when this started.

Do you have an idea what could be the issue? Could it be an issue inside libconnect?

Thanks Tracy (DNB)

gjaekel commented 2 years ago

Seems to be a duplicate of #18.

In getTitleHistory https://github.com/subhh/libconnect/blob/3691c6935245ecaeda57b94d45ad86aec45ef8d2/Classes/Domain/Repository/EzbRepository.php#L709-L722 there's a call to getPrecursor and getSuccessor: https://github.com/subhh/libconnect/blob/93aea9048722701e9ca93472cfd6ce607d909e39/Classes/Lib/Zdb.php#L344-L349 https://github.com/subhh/libconnect/blob/93aea9048722701e9ca93472cfd6ce607d909e39/Classes/Lib/Zdb.php#L437-L441 This both methods did a HTTP-request to the Backend ld.zdb-services.de in any case; that's the reason for a double call.

To avoid this, the result of a call to a identical backend URL might be cached and reused.