search

subhra74 / snowflake

Graphical SFTP client and terminal emulator with helpful utilities
GNU General Public License v3.0
2.18k stars 234 forks source link

feat(build): remove boilerplate code with lombok #92

Open mbocek opened 4 years ago

mbocek commented 4 years ago

85 Example of how to reduce boilerplate code.

eitch commented 4 years ago

I know everyone loves removing boilerplate, but an IDE can easily manage the getters and setters and thus this is just unnecessary dependencies... =) and complicates building etc.

mbocek commented 4 years ago

The build is straight forward. All major IDEs have support for Lombok (IntelliJ Idea, Eclipse...) As usual, the decision is on the maintainer. For me, less code is better.

aaabidunique commented 4 years ago

@subhra74 Please consider merging this PR as it will be quite helpful later while code cleanup.

andy-goryachev commented 4 years ago

please do not add unnecessary dependencies. removing boilerplate code is, in my opinion, not the most pressing issue in software development.

uli-heller commented 4 years ago

@andy-goryachev : I agree, removing boilerplate code is not the most pressing issue. @eitch : I often see projects having IDE generated getters and setters and equals and hashCode. The issue comes up when someone adds a property later on and doesn't keep all of these in sync. I personally like the lombok approach much better. So I would vote to merge the PR

aaabidunique commented 4 years ago

Lombok doesn't only provide getter/setter but also provide other functionality like logger, builders etc thats why I asked to get it merged. Anyways its up to the maintainer.