search

subject-f / cubarimoe

GNU Affero General Public License v3.0
60 stars 17 forks source link

Some MD series fail with HTTP status 500 #8

Open Daktyl198 opened 2 years ago

Daktyl198 commented 2 years ago

An example link: https://cubari.moe/read/mangadex/a1f8f17a-6c51-4a35-9205-bc70bb5fa826/

According to basic testing, it appears that the failure is related to the cors proxy used. For example, using the above link as a guide, trying to access one of the API urls used in the proxy source gives you a bit.ly link to their github instead of the requested resource: https://cors.bridged.cc/https://api.mangadex.org/manga/a1f8f17a-6c51-4a35-9205-bc70bb5fa826?includes[]=cover_art

I am unsure of why this would only fail for some series and not all, however.

funkyhippo commented 2 years ago

I appreciate the effort!

As it turns out, we actually stopped using that proxy precisely because they started enforcing API keys. That restriction is unfortunate since it worked well for letting us get around MD's rate limits; thus, I would consider the MD proxy EOL since we're bounded by the 5 r/s limit.

For that series specifically, it looks like it's failing because it's missing a description. I checked with MD staff and it's a known issue for data.attributes.description to be an empty array (instead of an empty object) in this scenario, which resulted in a parsing error. I'll push a fix for this.

funkyhippo commented 2 years ago

I'm not going to close this issue for now since I know there are other series that fail to load. Let me know if you come across any others.