subject-f / guyamoe

Kaguya Manga Reader Website
https://guya.moe
GNU Affero General Public License v3.0
462 stars 66 forks source link

cubari: Custom scrollbar uses move cursor instead of default (pointer) cursor #80

Open ErikHumphrey opened 3 years ago

ErikHumphrey commented 3 years ago

The custom scrollbar should use the pointer cursor rather than the move (grabber) cursor. It may also be possible to use CSS to change the look of the scrollbar rather than inventing a custom one, but I would imagine there is some functional reason for using a custom one here other than looks.

Cursor before:

image

Cursor after:

image

It's better UX to have scrollbar replacements retain the same pointer as other scrollbars; else, it ruins the illusion and feels bad.

Algoinde commented 3 years ago

The scrollbar is implemented exactly as you suggested, it's not a non-native implementation. The problem lies in the fact that the whole container is cursor-pointer'ed. I can put this on my list to fix if this annoys you.

ErikHumphrey commented 3 years ago

Ah; I wasn't too sure and should have checked the code first. I had a feeling that might be the case, but I didn't know that the WebKit scrollbar could overlay & inherit from page contents even on systems where the default puts the browser scrollbar beside the content rather than over it.

Yes, please fix it when you have the chance!