search

subject-f / guyamoe

Kaguya Manga Reader Website
https://guya.moe
GNU Affero General Public License v3.0
462 stars 66 forks source link

Gist QoL Updates (For API) #97

Closed AntsyLich closed 3 years ago

AntsyLich commented 3 years ago
  1. Add chapter as optional for "chapter" when chapter number starts from 1 every volume. e.g. Volume 1 Chapter 1, Volume 2 Chapter 1.
  2. Allow last_update in API. (Mostly for Tachiyomi Cubari Extension.)
funkyhippo commented 3 years ago

Thanks for the contribution! However, the active development for Cubari isn't in this repo at the moment.

As for the changes you've made:

  1. The chapter numbers are parsed from the key of the chapters dict, so the chapter key won't make a difference here.
  2. The schema for the chapter release dates is based on the group mapping from the chapter, so clients would not parse this.

I noticed you've made changes to the Tachi extension, so I can update the upstream repo to reflect the release time.

AntsyLich commented 3 years ago

Thanks for the contribution! However, the active development for Cubari isn't in this repo at the moment.

Well at least you'll notice if I add a PR here.

1. The chapter numbers are parsed from the key of the `chapters` dict, so the `chapter` key won't make a difference here.

Well yes it wont make a big difference but it will be a nice little QoL. As for example I'm compiling the "Oyasumi S**" Doujin chapter in a single space but as it has a bunch of sequel, prequel & side stories if I can add a custom chapter it'll be more easy to organize stuff. In case of the Doujin Vol. 1 Ch. 1, Vol. 3 Ch. 1 will be more aesthetic than Vol. 1 Ch. 1, Vol. 3 Ch. 5 (You should get what I mean)

2. The schema for the chapter release dates is based on the group mapping from the chapter, so clients would not parse this.

Ohh yeah...

I noticed you've made changes to the Tachi extension, so I can update the upstream repo to reflect the release time.

Appreciate it :)