subjectsplus / SubjectsPlus

Repository for the SubjectsPlus project. This is version 4.6 (July 2021); for version 3, select branch > versionthree; for version 2, select branch > versiontwo.
http://subjectsplus.github.io/
Other
45 stars 31 forks source link

update password hash algorithm #1473

Closed gmcharlt closed 3 years ago

gmcharlt commented 3 years ago

Currently, staff passwords are hashed using unsalted MD5, which is insecure. Updating it to salted bcrypt would guard against dictionary attacks if the contents of the staff table got compromised.

This would be doable by switching to PHP's password_hash() builtin. Double-hashing (e.g.,), using password_hash(md5($plainTextPassword)) would make upgrades straightforward, although there are some dependency issues:

cgb37 commented 3 years ago

Hello Galen! Thanks so much for your help. We really appreciate it. In regards to the php version, we are currently scheduled to release a new version with php 7.4 on feb 15.

gmcharlt commented 3 years ago

Great, if PHP5 (or at least < 5.5) support is about to not be factor, that would simplify things. I can work on a branch.