sublee / trueskill

An implementation of the TrueSkill rating system for Python
https://trueskill.org/
Other
742 stars 112 forks source link

Tiny documentation error with explanation of beta parameter #11

Closed rsimmons closed 8 years ago

rsimmons commented 8 years ago

The documentation describes beta as "the distance which guarantees about 75.6% chance of winning". I think the correct percentage should be 76.025% (rounded however you wish). While the difference is trivial, it might confuse other people.

I was curious where the 75.6 magic number came from so derived what it should be, using the formula for computing win probability (mentioned in another issue). If you consider a match of two players, with the player sigmas and draw margins being 0, and the difference in rating means equal to beta, the win probability simplifies to cdf(1/sqrt(2)), which is about 0.76025.

sublee commented 8 years ago

Thank you for the report. I agree on your opinion.

Should we describe Beta as 76.025% (Φ(1/√2))? Or approximately 80%? Which do you prefer?

sublee commented 8 years ago

Which win probability formula you used? If you used the last one, should the simple formula be Φ(1/√(2β)) instead of Φ(1/√2)?

Φ(delta of μ÷√(players×β²+sum of σ))
→ Φ(β÷√(2β²+0))
→ Φ(1÷√(2β))
rsimmons commented 8 years ago

I think there's a mistake in that simplification: Φ(β÷√(2β²+0)) has √(2β²) in the inside denominator, which simplifies to β√2, so we get Φ(β÷(β√2)) → Φ(1/√2).

I would probably describe beta as "the distance which guarantees about 76% (specifically Φ(1/√2)) chance of winning".

Also, thanks so much for your work on this project. When I discovered the TrueSkill site/papers I was excited to use it but the thought of implementing it from scratch made my heart sink a little :)

sublee commented 8 years ago

Oh, you're right. I had a mistake. Thank you for letting me know.

Would you give me a pull request to add you to the contributor list? If you don't care about the contributor list, I'll update the document myself.

sublee commented 8 years ago

I released TrueSkill-0.4.4 with your patch. http://trueskill.org/#version-0-4-4