Fixed a few language errors in comments and an old Python 2 legacy feature that had no use.

sublee / trueskill

An implementation of the TrueSkill rating system for Python

https://trueskill.org/

Other

742 stars 112 forks source link

Fixed a few language errors in comments and an old Python 2 legacy feature that had no use. #25

Closed bernd-wechner closed 3 years ago

bernd-wechner commented 6 years ago

As requested. Hope it's good. Included a few typo fixes.

coveralls commented 6 years ago

Coverage decreased (-0.02%) to 92.188% when pulling 536a20268057c0e9fe2b87bc195ee06dc8c957d9 on bernd-wechner:master into a8f24e8d58acd0f83ab9984f62c65f88721ed1c9 on sublee:master.

bernd-wechner commented 6 years ago

Not sure what the Travis failures are about. But curious.

sublee commented 6 years ago

Thank you for the good PR. Can you separate this PR to for comments and for long? I think they are not an atomic patch.

trueskill is intended to support both Python 2 and 3. So the __long__ magic method should not be removed. It would be great if you implement it with past.builtins.long to support both: http://python-future.org/compatible_idioms.html#long-integers

bernd-wechner commented 3 years ago

Sorry I dropped the ball on this. Thanks for finishing it up!

sublee commented 3 years ago

Sorry for my TOO late response. 🙏