add kwargs to global_env method

sublee / trueskill

An implementation of the TrueSkill rating system for Python

https://trueskill.org/

Other

742 stars 112 forks source link

add kwargs to global_env method #43

Closed anthony0727 closed 3 years ago

anthony0727 commented 3 years ago

Using the global_env.__trueskill__ as global env and it will be great if we can optionally pass kwargs to global_env() method!

e.g. we might want to pass backend='mpmath'

ts = trueskill.global_env(backend='mpmath')

thx!

coveralls commented 3 years ago

Coverage remained the same at 92.078% when pulling 369888c93e6c10d49ff75fdccfd7694bb6eafea7 on anthony0727:globalenv-kwargs into cd616d625973305a40d3259d9371cb430bf31dd4 on sublee:master.

sublee commented 3 years ago

Thank you for the feature request but I don't agree with it. I want to keep global_env() has no side-effect. setup() with arguments is a clear alternative and calling it is not complicated.

anthony0727 commented 3 years ago

네 알겠습니다! 감사합니다!