search

sublimehq / Packages

Syntax highlighting files shipped with Sublime Text and Sublime Merge
https://sublimetext.com
Other
2.95k stars 587 forks source link

[CSharp] Add the C# 11 type modifier `file` feature support #4034

Closed lindexi closed 2 weeks ago

lindexi commented 2 weeks ago

See https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/file

The file is the keyword of type modifier as the type visibility.

michaelblyons commented 2 weeks ago

Do you want to write some unit tests, too?

lindexi commented 2 weeks ago

Thank you, let me learn how to write unit tests in this project.

lindexi commented 2 weeks ago

@michaelblyons I added the unit test code, could you review my code?

michaelblyons commented 2 weeks ago

I have approved running the tests, but there are some test failures. Once those look good, I think it'll be clear to merge.

lindexi commented 2 weeks ago

@michaelblyons Thank you and I try fix the unit test. Sorry, I'm not familiar with test syntax.

michaelblyons commented 2 weeks ago

If you're having trouble, you can install the PackageDev package, click at end of the line you want tests for in the unit test file, and Cmd+Enter (or Ctrl+Enter) and it should write a test suite for that line.