sublimehq / Vintage

Vintage mode adds a vi style command mode to Sublime Text 2
http://www.sublimetext.com/docs/2/vintage.html
579 stars 76 forks source link

delete/yank up/down behavior inconsistent with vim #183

Open Shadyjames opened 11 years ago

Shadyjames commented 11 years ago

In vim pushing <d/y><up/down> will delete/yank the entire current line and the n lines above or below it. I have noticed that in vintage mode the behavior of these commands is instead equivalent to v<up/down><d/y>, where it will leave part of the current line and part of the final line depending on the cursors initial position.

I'm actually keen enough for this change that I might just implement it myself at some point, but I thought i'd post an issue first and make sure this wasn't intended for some reason.

brunocoelho commented 11 years ago

Hey @Shadyjames, I'm having the same problem. Delete/yank a bunch of lines is my favorite feature. If you know how to fix it please do it as soon as possible.

Shadyjames commented 11 years ago

I did look into it, and it seemed difficult enough that i was like "Fuck it! I don't need it that bad", but if its bothering you as well I'll make a weekend project out of it this or next weekend. Contribute to open source and what not

On Thu, Aug 29, 2013 at 2:00 PM, Bruno Coelho notifications@github.comwrote:

Hey @Shadyjames https://github.com/Shadyjames, I'm having the same problem. Delete/yank a bunch of lines is my favorite feature. If you know how to fix it please do it as soon as possible.

— Reply to this email directly or view it on GitHubhttps://github.com/sublimehq/Vintage/issues/183#issuecomment-23465551 .

Whee!

brunocoelho commented 11 years ago

Hey, that's awesome. I hope I could help you with this bug but I think I'm not capable. I don't know python enough.

Shadyjames commented 11 years ago

First time i've done a pull request, no idea how to post the patch to this issue, so here's a link instead https://github.com/sublimehq/Vintage/pull/187

brunocoelho commented 11 years ago

Hey @Shadyjames, really nice. I will test as soon as possible and give you a feedback. @sublimehq, what do you think?