search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

searching for a file in the 'files' tab causes sublime merge to crash #1296

Open ArnonHevlin opened 3 years ago

ArnonHevlin commented 3 years ago

Version info

Description

after searching for a file in the 'files' tabs (with the shortcut ctrl+alt+f), leaving the search text of the file as is and going back to the commits tab (ctrl+2), then scrolling through the commits (with up arrow key and down arrow key), sublime merge crashes.

furthermore, closing sublime merge after going back to the commits tab and before the crash, causes this issue to be saved in the "Session.sublime_session" or "Auto Save Session.sublime_session", meaning that if I reopen sublime merge, it will crash when scrolling through the commits unless I delete those files. Another solution is to press ctrl+alt+f again and delete the search text.

I was able to reproduce this issue on different computers and repositories, but for some reason I couldn't reproduce it on small projects, so when trying to reproduce this issue, please try to do it on a big project

Steps to reproduce

Steps to reproduce the behavior:

  1. Open a repository (preferably of a big project with plenty of commits)
  2. click on a commit
  3. open search in the 'files' tab: ctrl+alt+f
  4. type some text, even one letter is enough
  5. press ctrl+2
  6. scroll through the commits with the up and down arrow keys until sublime merge crashes

Expected behavior

sublime merge should be able to scroll through the commits without crashing

dpjohnst commented 3 years ago

Hi @ArnonHevlin,

Thanks for reporting this issue - I've been able to reproduce the issue and am working on a fix. I'll keep you updated as things progress. Cheers, - Dylan

dpjohnst commented 2 years ago

Hi @ArnonHevlin,

Thanks again for reporting this issue - it has now been resolved in Sublime Merge Build 2064 (dev). I'll update here again when the next stable build is released.

Kind regards, - Dylan

ArnonHevlin commented 2 years ago

That's great, thanks for the update!

ArnonHevlin commented 2 years ago

There appears to still be an issue that I didn't previously report:

When you don't delete the search text and then try to navigate between pages with ctrl+pageup and ctrl+pagedown, some pages are skipped over. Also, sometimes when you click on the page tab with a mouse, the wrong page tab is selected.

srbs commented 2 years ago

@ArnonHevlin, probably wise to create a new bug report for that