search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

Can no longer customise commit message context menu with `Widget Context.sublime-menu` #1310

Open alecgibson opened 3 years ago

alecgibson commented 3 years ago

Version info

Description

I previously had a custom submenu configured for the commit message context menu configured in Widget Context.sublime-menu which is no longer working.

This was working fine up until upgrading to the latest build today.

Steps to reproduce

  1. Create file: ~/Library/Application Support/Sublime Merge/Packages/User/Widget Context.sublime-menu
  2. Insert a custom menu (see below)
  3. Right-click on the commit message text box, and see that the menu entry isn't there

Expected behavior

I'd expect the custom menu to be there

Screenshots

This is where the context menu entry used to show up (but no longer does)

Screen Shot 2021-10-26 at 10 09 14
srbs commented 3 years ago

Can confirm not working in newer builds with no modifications of context_menu values in any of the settings files.

dpjohnst commented 3 years ago

Hi all,

Thanks for bringing this to our attention, and apologies for any inconvenience!

Recently we've added support for navigating to commits referenced in commit messages. In adding this, Commit Message.sublime-menu was also added, containing the navigate_to_context_commit command.

In doing so, the default Widget Context file has been disabled. I'll be investigating this further, but in the meantime I recommend renaming your menu file to Commit Message.sublime-menu, as this will be the default menu file for commit messages moving forward.

I'll keep you updated as we resolve this issue.

Cheers, - Dylan

srbs commented 3 years ago

Good catch @dpjohnst, not sure how I missed that. I would recommend updating the Sublime Merge docs to reflect these changes & remove/update references in the default Merge.sublime-settings, Preferences Widget.sublime-settings, & Widget.sublime-settings. Maybe even Console Input Widget Context.sublime-menu in Console Input Widget.sublime-settings is affected by these changes as well.

dpjohnst commented 3 years ago

Hi @srbs,

Thanks for sharing this feedback! We'll be updating the Menus documentation shortly to indicate the presence of Commit Message.sublime-menu

To clarify, Widget Context.sublime-menu will still be used for these general text entry widgets such as the preferences, console etc.

Cheers, - Dylan