search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

There is no Default/Preferences.sublime-settings #166

Open tyler8691 opened 6 years ago

tyler8691 commented 6 years ago

Version info

Description

When attempting to modify Sublime Merge preferences, there are no default preferences to work from. This makes it difficult to know the values that can be entered.

Steps to reproduce

Steps to reproduce the behavior:

  1. Open Sublime Merge
  2. Click the menu bar -> Preferences -> Edit Settings

The Preferences.sublime-settings file is opened with the following header:

// Settings in here override those in "Default/Preferences.sublime-settings",
// and are overridden in turn by syntax-specific settings.

However that file does not exist on the filesystem. It is difficult to know what (or if any) preferences can be applied.

Expected behavior

The Default/Preferences.sublime-settings file should be included with the installation. If there are no configurable preferences, it should be indicated clearly to the user so they don't get confused.

If the user has Sublime Text, it would be ideal if the Preferences.sublime-settings file was opened side by side with the Default/Preferences.sublime-settings, for easy comparison.

deathaxe commented 6 years ago

The default Preferences.sublime-settings exists in the Default - Merge.sublime-package. There is just no easy way to open the side-by-side settings view as SM can't expect ST to always be available.

Therefore the attempt to edit Preferences via Command Palette was made. But it needs some more work to mature to a general flexible solution.

tyler8691 commented 6 years ago

Ok I gotcha, thanks!

I finally found that file after showing package contents on the .app, changing the .sublime-package to .zip, and decompressing. Am I missing something? Shouldn't it be easier to find this?

deathaxe commented 6 years ago

The package/file structure is derived from ST and changes made for SM shouldn't break ST features/settings.

May probably need some cleanup here and there.

tyler8691 commented 6 years ago

I don't think there needs to be a change to the package/file structure, there just needs to be an easier way to view it as a user of Sublime Merge. Even a menu option for "Default Preferences" would suffice.

Right now the discoverability of this file is essentially nonexistent, preventing users from understanding how to modify their own custom preferences properly.

deathaxe commented 6 years ago

The main issue with SM (but also with ST's side-by-side view) is: A menu item like "Open Default Preferneces" would open only one specific file by default, but the default Preferences in SM are aggregated from 3 files:

Which one to show?

andreiborisov commented 5 years ago

Which one to show?

Maybe SM can merge them dynamically before showing? Alternatively inner structure of settings can be reorganised.

RobertPaauw commented 2 years ago

Just stumbled into this issue today (on Sublime Merge 2074 on Windows 10). Default - Merge/Preferences.sublime-settings does not contain all keys (like hardware_acceleration and ignore_diff_white_space). I am unable to find the other files mentioned in one of the earlier comments (Default/Preferences.sublime-settings and Default/Preferences ().sublime-settings) that are suggested to contain additional options. This also appears to be related to #1369.

What would be the location of these files?

deathaxe commented 2 years ago

Default denotes ST's virtual filesystem. Shipped packages are zipped into *.sublime-package files. So Packages/Default.sublime-package is.

themilkman commented 1 year ago

ST integration using edit_settings would be really helpful for keymaps & Preferences (Preferences.sublime-settings).