search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
271 stars 14 forks source link

Finishing a Git Flow release without tag message does not create a tag #1777

Open nagromc opened 1 year ago

nagromc commented 1 year ago

Version info

Description

Finishing a Git Flow release without tag message does not create a tag. Whereas, the command git flow release finish (without tag message) creates a tag.

Steps to reproduce

Steps to reproduce the behavior:

  1. Open repository
  2. Initialize Git Flow
  3. Start a Git Flow release branch
  4. Run command Git Flow: Finish Release Branch on the new branch, but without tag message

Expected behavior

A tag should be created on the new commit on the stable branch (master/main).

Debug Information

It appears that Sublime Merge adds a --notag flag to the command, which is not expected coming from the CLI world. It has been confirmed by @dpjohnst in this comment: https://github.com/sublimehq/sublime_merge/issues/1092#issuecomment-824508921

dpjohnst commented 1 year ago

Hi @nagromc,

Thanks for reporting this!

From my understanding, finishing a release with git flow on the command line will prompt for a tag message. If none is provided, it will error out:

fatal: no tag message?
Fatal: Tagging failed. Please run finish again to retry.

I.e. the user can either provide a tag message, or provide the --no-tag flag. Does this differ from your understanding? If so, what would the expected behaviour be here?

Thanks for your help, - Dylan from Sublime HQ

nagromc commented 1 year ago

Hi @dpjohnst,

Thanks for your reply.

I'm currently on leave. I'll reply as soon as I'm back.

nagromc commented 11 months ago

Hi @dpjohnst,

You are right: from the CLI, if no message is given when prompted, tagging will fail. Sorry about that.

What I expect though is at least the creation of a lightweight tag; i.e. without a tag message. Not sure if it is feasible through the CLI though.

If it is not feasible, I think you should make clearer the fact a tag won’t be created if no tag message is provided. The Optional Tag Message caption when invoking the Git Flow: Finish Release Branch action is kind of confusing to me.