sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
274 stars 14 forks source link

1Password SSH Agent & Sublime Merge compatibility #1800

Open rj-davidson opened 1 year ago

rj-davidson commented 1 year ago

Version info

Description

Using 1Password SSH Client to manage SSH Keys for Github. This works via command line but Sublime Merge is only capable of checking out branches. Pulling, pushing, committing and fetching along with everything else tested fail with this message:

error: Found argument 'git-upload-pack 'repo/repo-api.git'' which wasn't expected, or isn't valid in this context

USAGE:
    op-ssh-sign [OPTIONS] -Y <mode> [--] [payload]

For more information try --help
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I can preform all these operations successfully from command line as well as other lesser git tools such as Jetbrains IDE's git features. I would prefer to continue using Sublime Merge if this bug can be fixed.

Screenshot 2023-08-25 at 10 06 01 AM

Steps to reproduce

Steps to reproduce the behavior:

  1. Configure 1Password SSH (https://developer.1password.com/docs/ssh/get-started/#step-4-configure-your-ssh-or-git-client)
  2. Test 1Password SSH Agent via command line (as suggested in article linked in step 1)
  3. Try to use sublime merge to fetch, pull, commit or push to a repo.

Expected behavior

This should not succeed in sublime merge and an error should be logged with the verbiage noted in the description.

Debug Information

`=== App Version Information === Build: 2091

=== Git Version Information === Using Git: /Applications/Sublime Merge.app/Contents/Resources/Git/bin/git (bundled) git version 2.39.1 PATH: /opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Little Snitch.app/Contents/Components:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/redacted/.nvm/versions/node/v20.3.1/bin:/opt/homebrew/bin:/opt/homebrew/sbin (from shell) environment variables loaded using: /bin/zsh -l

=== Browse Page Information === HEAD: 44c190e5eb70b7470e04411c68243c31f219173c Is in merge: 0 Is in cherry_pick: 0 Is in rebase: 0 Is in revert: 0

=== Git Status Information ===

=== Our Status Information ===

=== Git Config Information === branch.staging.merge=refs/heads/staging branch.staging.remote=origin commit.gpgsign=true core.bare=false core.filemode=true core.ignorecase=true core.logallrefupdates=true core.precomposeunicode=true core.repositoryformatversion=0 filter.lfs.clean=git-lfs clean -- %f filter.lfs.process=git-lfs filter-process filter.lfs.required=true filter.lfs.smudge=git-lfs smudge -- %f gpg.format=ssh gpg.ssh.program=/Applications/1Password.app/Contents/MacOS/op-ssh-sign lfs.repositoryformatversion=0 remote.origin.fetch=+refs/heads/:refs/remotes/origin/ remote.origin.url=git@github.com:velvetfs/velvet-api.git user.email=hello@rjd.app user.name=RJ D user.signingkey=ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIG6KKXzgMTNZ1AeGRaRYpSzecgxPLJnGyyORkdN7g4ol

=== Our Config Information === Git Config Path Information Using config path: /etc/gitconfig Using config path: /Users/redacted/.config/git/config Using config path: /Users/redacted/.gitconfig Using config path: /Users/redacted/Developer/velvet/velvet-api/.git/config

Our config output is identical to the Git config output

=== Git Attributes Information === git check_attr --all output

=== Our Modified Files Newline Normalisation and EOL Information ===

=== Our Modified Files Flag Information === Ignoring symlinks: 0 `

Screenshots

Screenshot 2023-08-25 at 10 13 05 AM