search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
272 stars 14 forks source link

No way to tell if "Working Directory" view is up-to-date #1905

Open geoffreygaren opened 2 months ago

geoffreygaren commented 2 months ago

Problem description

Steps to reproduce:

  1. Open a repository in Sublime Merge
  2. Make the "Commits" tab active
  3. Select the virtual top commit (representing your working directory changes) --> Notice that you have no changes
  4. Make a change in the working directory --> For a few seconds, or up to a minute, Sublime Merge shows a UI that claims, incorrectly, that you still have no changes

When you're just reviewing changes casually, this is a little annoying.

But if you mix Sublime Merge with command-line use of git, it can cause you to think you have no local changes, encouraging you to push an incomplete commit.

Preferred solution

It would be nice if Sublime Merge listened for filesystem change notifications in the repository folder hierarchy. In the time between receiving a notification and completing the git commands to update the UI, the UI could indicate that it is was out of date. Options include blanking the UI entirely, greying out the last known good version of the UI, showing a progress indicator, etc. Any breadcrumb to help the user know that an update was in progress would be a great help.

jnns commented 2 months ago

This might be related to https://github.com/sublimehq/sublime_merge/issues/1890 Or at least the delay in Sublime Merge also plays a role in that ticket.

I noticed that an action carried out in Sublime Merge is instantly applied and visible via the Git CLI but the result of that operation only shows with a huge delay in Sublime Merge itself.

dpjohnst commented 1 month ago

Hi @geoffreygaren,

Thanks for reaching out, I'll be investigating this further.

When you have a chance, could you share your Sublime Merge debug information here.

This can be found in the application menu under Help > Debug Information. Before posting it here, please take a moment to review the debug information and remove any information you consider sensitive (git remote config, git user etc).

Kind regards, - Dylan from Sublime HQ