search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

Does not remember its maximization state opening it with Open Git Repository #276

Open evandrocoan opened 6 years ago

evandrocoan commented 6 years ago

Version info

Description When I open a file with: image

From Sublime Text, Sublime Merge window does not remember maximization state, i.e., it always opens un-maximized.

Expected behavior If the last time I closed Sublime Merge, its window was maximized, it is expected to it be maximized next time I open it from Sublime Text menu.

Steps

  1. Open Sublime Text with some git project
  2. Hit the context menu, Open Git Repository
  3. Sublime Merge window opens
  4. Maximize it and close
  5. Go to Sublime Text and hit again Open Git Repository on the context menu
  6. Now, Sublime Merge windows opens, but it is not maximized.
  7. It is expected for it to be maximized as I just closed it with maximized state

Related:

  1. https://github.com/sublimehq/sublime_merge/issues/112 Maximization state forgot between launches
chrisjbillington commented 5 years ago

Likely duplicate of #396

evandrocoan commented 5 years ago

I posted this first (11/2018), then, that other issue (02/2019) is duplicating me, not the opposite. And window size is different than maximized/unmaximized state.

chrisjbillington commented 5 years ago

Apologies, you're right, you were first. It is almost certainly the same bug though, since maximisation state is restored when opening sublime merge by itself via the OS menus or smerge on the command line, whereas it is not restored when running smerge <repo> or launching it from sublime text. These is the same pattern as with the issue issue, so I think it is probably the same underlying issue.

PatTheMav commented 4 years ago

Can confirm that when launched normally or from CLI without repo path window state is restored, but opening from CLI with smerge <repo> resets it.