search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

Query results not sorted properly #474

Open VulumeCode opened 5 years ago

VulumeCode commented 5 years ago

Version info

Description

Git's time resolution is only 1 second. Having multiple commits per second seems to create problems for sorting the query results. This leads to a distorted view on history. It only appears to happen when branching and merging is involved.

Steps to reproduce

Write a script to change a file and commit it many times in a second, randomly branching and merging. In Sublime Merge look at the history, then search for the file. Notice that the commits are out of order.

Expected behavior

Commits in query results and in the regular view appear in the same order.

srbs commented 5 years ago

I'm not able to reproduce this issue. Could you provide some screenshots and the expected correct ordering or a script that demonstrates the issue?

Also, what are you comparing against? I ask because I know that GitHub doesn't always handle sub-second commit ordering correctly.

VulumeCode commented 5 years ago

History view, in order:

regular

Search (including merges):

search

Also happens for a regular search:

searchfiles

I numbered the commits. I'm comparing against the regular history view of the sublime merge, there they are in the correct order.