search

sublimehq / sublime_merge

Issue tracker for Sublime Merge
https://www.sublimemerge.com
276 stars 14 forks source link

Ctrl+Alt+{Up,Down} vs. menu Repository -> {Push...,Pull...} #946

Open ratijas opened 4 years ago

ratijas commented 4 years ago

Version info

Problem description

Shortcut behavior does not match menus. In other words, there are certain menus with shortcuts, but what happens when you select a menu vs. enter the shortcut are two different stories.

Shortcut Ctrl+Alt+Up and toolbar button (not an arrow on the right side of it) activate quick push/pull without additional options. But menu items Repository -> {Push...,Pull...}, Command Palette -> {Push..., Pull} and drop-down menus on the right sides of toolbar buttons are triggering push/pull WITH additional options.

I'm in conflict with menu items that state that their shortcut is XXX — but when you actually enter that XXX you get different behavior compared to what would have happened if you clicked the menu item itself.

I see a need for quick mode, but it should not come at a price of such confusion.

I also feel like we need a shortcut for push/pull WITH options.

Preferred solution

Change Repository menu and default shortcuts like this:

~...      stash  actions      ...~
----------------------------------
Pull                 Ctrl+Alt+Down
Pull with...   Ctrl+Shift+Alt+Down
Push                   Ctrl+Alt+Up
Push with...     Ctrl+Shift+Alt+Up
----------------------------------
~...      branch actions      ...~

Alternatives

Not that I know of any alternatives...

ratijas commented 3 years ago

As of Stable Channel, Build 2038, the issue is still relevant.

ransagy commented 3 years ago

I don't know if its strictly related or merits its own issue; but for me those never trigger at all, any of those shortcuts. I am on windows though, So it could be some other mixup. If you think its separate, Feel free to split this and ill fill in more details.

ratijas commented 2 years ago

Still relevant, still needed. At this pace, I wish it was open source so I could just send a patch instead of passively waiting two years.