search

sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
811 stars 39 forks source link

File deletion fails without error message on OS X filesystems without a trash folder #1188

Open FichteFoll opened 8 years ago

FichteFoll commented 8 years ago

From @taruti on March 24, 2016 19:50

This might be two issues:

1) Errors on file deletion are not reported in DeleteFileCommand, the return value from send2trash is ignored making it hard to see what happens. Handling the errors like DeleteFolderCommand does could make sense.

2) File deletion on filesystems without a trash folder is not supported.

send2trash ends up calling FSMoveObjectToTrashSync from CoreServices. The function returns an errors and does not remove the file on filesystems without a trash can. OSXFuse (3.2.0) sshfs is an example of such a filesystem, but in general this is the case for most fuse filesystems.

Finder handles errors from FSMoveObjectToTrashSync and then asks the user and deletes the file upon user confirmation. Doing likewise might be a solution.

Tested with Sublime Text build 3103.

Copied from original issue: SublimeTextIssues/DefaultPackages#184

strib commented 7 years ago

Has there been any progress or planning on this issue? Is there anything we can do to help move it along? Thanks!

keith-hall commented 7 years ago

similar problems and discussions have also been had here re Linux, which may be relevant: https://github.com/SublimeTextIssues/Core/issues/209

wbond commented 4 years ago

@BenjaminSchaaf Was this fixed by your delete files changes?

BenjaminSchaaf commented 4 years ago

@wbond Not sure. Couldn't test macOS so this issue wasn't on my radar at the time.