search

sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
807 stars 39 forks source link

show_popup doesn't display remote images #1378

Open Electrofenster opened 8 years ago

Electrofenster commented 8 years ago

Summary

I tried to display a random image in Sublime Text 3 from a URL but it didn't work, when I convert the image to base64 the img-tag works. With this Image we test it: https://www.sublimetext.com/images/linux_48.png

Expected behavior

I was expected to see no image

Actual behavior

I got the image to display that i want.

Steps to reproduce

  1. open console in st3
  2. paste this line:
view.show_popup('<img src="https://www.sublimetext.com/images/linux_48.png">')

and we get a empty popup

  1. paste this line:
view.show_popup('<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACkAAAAwCAYAAACMuVOlAAAJbUlEQVR4Xs2YeXBV1RnAf+e+dcnGSx4JISuyyBLBBZRFipXqjCIoZSY4DIOiHXcKiBRRqkGq1qWAIIvt8EcZB0VaaC3aDA5DUIRSijEQmZomEEIWIUL25eW9d3rfmXunt2+SCQFM+5v55t53k3fml+985zvnhmvICGA1UAJ0Au3AUeDnQCb/B3xkiMnYSEpKkkADsJwrROPqWQXMARzEIIRg1qxZjB8/PlG//zWw8n8lucJ0ohsOHDjAiRMnZBTgZeBm+ojg6hhv1J3sw1jvAk/3ZyYno0C43W66IyMjgxjm9fd0DwKYMGECt956K9nZ2ZhMnDiRFStWMG3aNPUzIQSABJKAwf0p6Zg0aRL79+9XEQgEAMjMzKSoqIjXXnuN7du3K1EppbW8JvenZDAvL4/hw4ezefNmVq58AYCFCx9VC0YIwfr161mzZg12ux0Lkf6UvFRfX09tbS1FB7+g+UI5YwZDx/elfFV8EoCNGzcqWa/Xi4Xz/Sl5/mxVFQUvvUSe6wPuy1jGiX1eFv94J9PTXyT/Tlj2zDy+PPIVTU1NWBjan5I1pcVHuTPpVVYthqSBQEciqZlw0/WCHW9m89iPXqH0j+OJ4a7+lDz34FSYNCUIEUA4IHIJIbzgzCEcauJ0WYT59xHL9P6UrD51VnD2tDGS7EISRGp+6s6eovL0JXKHwo5PAgCMGjWK0aNHA8QBN/TXjqOv7JFy6YN5TEjdSc5QkBiEoa5pBJ3JT1IfyWP27JmEQiEefvhhCgsLqaioeBko6A/JOXoL+mjr1vf4R+EWpqS/T+IAScNFjfO2R8i7t4BBaQHVI/Pz89m1a1e0FSlZAxsQ+SEl44DyGTNmDNy9ezdffHmEkmOH8ToFucPHcOOEyfiT4jE5c+YMubm5GJh7/WfAT/gBeReQJ0+elFGam5vl0aNH1efW1lb1LBKJWK9y3rx5EjAjAoSBWT9UJp8F3nr77bdZunSpmk4hBF1dXdhsNjRNM59h5dtvv2XEiBHE0AZkA/XXcnXfArwRPXHPnz8fKw6HQwlaULJ6JlUdZmVlMWzYMCxIwAscBmzXUvI9QMvJyRElJSUqe0IIgsGgypSxs6hn+rRTXFzM3r172bNnD8ePH2fmzJlYEIboUGDRtZJ8BLgRkNGjWGpqqsqSlBKn08mQIUNISEiIflbh8/lUXxw7diwpKSmUlZWp1wnjnGnu5wIFvwEGXG1NuoAqfZoDLS0t1NXVkZycjIlZg+a1OxoaGtAXF4cOHWL16tUkJibS0dFBZ2enudoPAVOuJpOT9cwMiNbWtm3booJKyMAU60lQyet1zNSpU5k7d270Xkl6PB7rtN8M5F2hpJKYnZaWZtcPtKoxmxm7XMwsu91utXjGjRunara9vZ2hQ4eaom5g4RVPtz54h756XYsXL1ZTZaGvwopFixaxYcMGAFW3paWl1hWvXUkmV+rT7Io2bH2H6TZLjY2NSvYyUWImFy9ejN2J7u+rpB9YqdegFDrRl67uuHDhAn0hPT0dA+uBWKBgTl8lfwb49OlWraQHVJ/sC6r99PzaO7avkvkA7e1BER8fTw+oftkHzNJQ/bO6uhorfa5Jn5uvVz0CIzMvkJCQaC6UK5OU0pSjpaVNNf5AQB3lVI0OGjQIg0N9kmz+XLt+9RI/B7Y6EE2f8ofde812ggV1TuwVIaCjAlm9BlH7Ok3NHZw6dSraitTq9vniGHWdhylj2dKr5JYHUVR+yA5hD9xGKEdiv46P10sKnpuht46NpmjMQuidtsqtiPoPmTysBmQQK/Xf/YtPNqRTtG3w2l4lmxvJ3fcyq9IyyEf4pTISbiRpvL8m2uOe4YknHo/dTXrtlaFQmJrKcxCp4PyZSnKSMSHOAWuf0sjOaJZCkN6j5FebeP3SPjqf/AVlt0+nwOn2CCk8AoUEWxp5o10sXwBbtmxVJ219P77sRl5TU03ZP2uANgLpsPkJKHgAlt8Dfy6ABXMkhKRANjvqP8EVPByz4/xtLTk33cY3dneaB+wS0AUTEcINSBQIZESX0soZ8wCUVoC+VaKfxtVe3hu1tXV8+fu53D+tCJsdLtZDaxM4neBPc+Dw3IBEgIwgQ3Vv2W6pec6aSaqraA+HaYEE0FKFHoYggDAChJaEDCWw7lnQNNRpSD8vXla78XjcdLR20NKCwp8CmUMgNQMczjQzDQBSc6QvCx3L3tW8D01g8Op04p5+nlPxA/wZ2HIAQY/ICIgT5C+LcFHcwzvr3mDkyJH0xrp166jbv4RlT0LKQDdoOebrDggfoIFROlJH6MhI23E7BnYH0uFEIly9nzuEBuEAH75eS3HoKSVoHjKsmTM/h8NhNm3axJIlS3hzvppe0AaC5qN7pOkAwjVOw2Dc3STrkl6J15TEyHy3Y0jhVlfKFlB17pwpZMqp0OXU/yfvuOMOdepx2GDwQHB7NBBekN0NDGo52IQIBVubwl2X5pqZdPniydQ0EkS4UiLbBVoC4AKpobBIIDCfMyRwnp/enUngxvncPnmiymJ5eTkHDx7k2LFjWNE0yEgBm90GSGsuEFKCkEgihDqbw+VltTtHzmtbCATNFeF74SGyn5nNQY8Xv2YDux1pd2hC7SQ2N5AAIhFwAhGI1IC8QF0VbP8Aln/Q85yZ934fFL4Co24WeBNSQfgBDegAmmVLQ4s4eaLj7zsKw7965y8cAbqAFgFogM8Ix4v38tCwDOb4B5AbF48jaQBOfwpaspom0DQBQiIjcOl7ZFUF4uPP4Je7aQdC5kowrmHj3gn6WF6cf3oeR9YwCKSCy20nIqG1KUTlaWTRF+xe/D5rBHRIaANagFYzkx5D0msM6PTaGHhDFtlZKQwelcHYMbncmZWJ3x+A6ALr6opuY4jyMhrf/Jitxec4AjQaol1GhAFjGkj1Osn87aOsyM7GF5+IsNmRwU5ETRXsOcSLv/ucQuN77UCrGQIFNkPUa7m6jXAZP+e+Mdxyz03kp/jJsWk4GhtoXvtXHiupoRroNMRMBOAwxnMZ4Xz8du6aOIIFbhd2NGRbGy07D7Pq028osQi2GdEeDRGzRbrNsA5sSNpRIIf4SUhNwHnsLN91RWg35DpjRB2WcZxGOACZ7CUu248vHKHr6xrqLd8LGgXablw76aEh2qyDGmEzQgOw1FzIMr1BI7osWXRawm4ZQ1jGCVvHsETkct8WNUvYrA0IiMSEpHuERU6LlTRFLfex8G9rfcBPH/TAvAAAAABJRU5ErkJggg==">')

and we see the image in our popup

Environment

FichteFoll commented 8 years ago

The documentation for minihtml only mentions http:// and not https://. Maybe that is the issue?

Electrofenster commented 8 years ago

@FichteFoll nope, I got only an empty popup. Build 3124

liuhaopen commented 7 years ago

I got an empty popup too. Build 3126

keith-hall commented 7 years ago

Interestingly, this crashes 3128...

Dump Summary
------------
Dump File:  3e3cbcee-0fa2-475a-9d1a-075cdf66107c.dmp : C:\Program Files\Sublime Text 3\3e3cbcee-0fa2-475a-9d1a-075cdf66107c.dmp
Last Write Time:    2017-04-13 09:30:38
Process Name:   sublime_text.exe : C:\Program Files\Sublime Text 3\sublime_text.exe
Process Architecture:   x64
Exception Code: 0xC0000005
Exception Information:  The thread tried to read from or write to a virtual address for which it does not have the appropriate access.
Heap Information:   Not Present

System Information
------------------
OS Version: 6.1.7601
CLR Version(s): 

Modules
-------
Module Name Module Path Module Version
----------- ----------- --------------
sublime_text.exe    C:\Program Files\Sublime Text 3\sublime_text.exe    1.0.0.1
ntdll.dll   C:\Windows\System32\ntdll.dll   6.1.7601.19135
kernel32.dll    C:\Windows\System32\kernel32.dll    6.1.7601.19135
KERNELBASE.dll  C:\Windows\System32\KERNELBASE.dll  6.1.7601.19135
user32.dll  C:\Windows\System32\user32.dll  6.1.7601.19061
gdi32.dll   C:\Windows\System32\gdi32.dll   6.1.7601.19091
lpk.dll C:\Windows\System32\lpk.dll 6.1.7601.18985
usp10.dll   C:\Windows\System32\usp10.dll   1.626.7601.19054
msvcrt.dll  C:\Windows\System32\msvcrt.dll  7.0.7601.17744
comdlg32.dll    C:\Windows\System32\comdlg32.dll    6.1.7601.17514
shlwapi.dll C:\Windows\System32\shlwapi.dll 6.1.7601.17514
comctl32.dll    C:\Windows\winsxs\amd64_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18837_none_a4d981ff711297b6\comctl32.dll   5.82.7601.18837
advapi32.dll    C:\Windows\System32\advapi32.dll    6.1.7601.19135
sechost.dll C:\Windows\System32\sechost.dll 6.1.7601.18869
rpcrt4.dll  C:\Windows\System32\rpcrt4.dll  6.1.7601.19135
shell32.dll C:\Windows\System32\shell32.dll 6.1.7601.19135
ole32.dll   C:\Windows\System32\ole32.dll   6.1.7601.19131
wininet.dll C:\Windows\System32\wininet.dll 11.0.9600.18205
api-ms-win-downlevel-user32-l1-1-0.dll  C:\Windows\System32\api-ms-win-downlevel-user32-l1-1-0.dll  6.2.9200.16492
api-ms-win-downlevel-shlwapi-l1-1-0.dll C:\Windows\System32\api-ms-win-downlevel-shlwapi-l1-1-0.dll 6.2.9200.16492
api-ms-win-downlevel-version-l1-1-0.dll C:\Windows\System32\api-ms-win-downlevel-version-l1-1-0.dll 6.2.9200.16492
version.dll C:\Windows\System32\version.dll 6.1.7600.16385
api-ms-win-downlevel-normaliz-l1-1-0.dll    C:\Windows\System32\api-ms-win-downlevel-normaliz-l1-1-0.dll    6.2.9200.16492
normaliz.dll    C:\Windows\System32\normaliz.dll    6.1.7600.16385
iertutil.dll    C:\Windows\System32\iertutil.dll    11.0.9600.18212
api-ms-win-downlevel-advapi32-l1-1-0.dll    C:\Windows\System32\api-ms-win-downlevel-advapi32-l1-1-0.dll    6.2.9200.16492
userenv.dll C:\Windows\System32\userenv.dll 6.1.7601.17514
profapi.dll C:\Windows\System32\profapi.dll 6.1.7600.16385
apphelp.dll C:\Windows\System32\apphelp.dll 6.1.7601.19050
AcGenral.dll    C:\Windows\AppPatch\AppPatch64\AcGenral.dll 6.1.7601.19050
sspicli.dll C:\Windows\System32\sspicli.dll 6.1.7601.19135
sfc.dll C:\Windows\System32\sfc.dll 6.1.7600.16385
sfc_os.dll  C:\Windows\System32\sfc_os.dll  6.1.7600.16385
dwmapi.dll  C:\Windows\System32\dwmapi.dll  6.1.7601.18917
mpr.dll C:\Windows\System32\mpr.dll 6.1.7600.16385
imm32.dll   C:\Windows\System32\imm32.dll   6.1.7600.16385
msctf.dll   C:\Windows\System32\msctf.dll   6.1.7601.18731
api-ms-win-core-synch-l1-2-0.DLL    C:\Windows\System32\api-ms-win-core-synch-l1-2-0.DLL    10.0.10586.9
dbghelp.dll C:\Windows\System32\dbghelp.dll 6.1.7601.17514
CRYPTBASE.dll   C:\Windows\System32\CRYPTBASE.dll   6.1.7601.19135
uxtheme.dll C:\Windows\System32\uxtheme.dll 6.1.7600.16385
DWrite.dll  C:\Windows\System32\DWrite.dll  6.2.9200.17568
cryptsp.dll C:\Windows\System32\cryptsp.dll 6.1.7601.18741
rsaenh.dll  C:\Windows\System32\rsaenh.dll  6.1.7600.16385
RpcRtRemote.dll C:\Windows\System32\RpcRtRemote.dll 6.1.7601.17514
AppHookWIN6064_6C993CE0-151E-4CBB-8F99-BB9E5B52CF5F.dll C:\Program Files (x86)\DisplayFusion\Hooks\AppHookWIN6064_6C993CE0-151E-4CBB-8F99-BB9E5B52CF5F.dll  8.0.0.16
psapi.dll   C:\Windows\System32\psapi.dll   6.1.7600.16385
winmm.dll   C:\Windows\System32\winmm.dll   6.1.7600.16385
secur32.dll C:\Windows\System32\secur32.dll 6.1.7601.19135
api-ms-win-downlevel-advapi32-l2-1-0.dll    C:\Windows\System32\api-ms-win-downlevel-advapi32-l2-1-0.dll    6.2.9200.16492
api-ms-win-downlevel-ole32-l1-1-0.dll   C:\Windows\System32\api-ms-win-downlevel-ole32-l1-1-0.dll   6.2.9200.16492
ws2_32.dll  C:\Windows\System32\ws2_32.dll  6.1.7601.17514
nsi.dll C:\Windows\System32\nsi.dll 6.1.7600.16385
crypt32.dll C:\Windows\System32\crypt32.dll 6.1.7601.18839
msasn1.dll  C:\Windows\System32\msasn1.dll  6.1.7601.17514
mswsock.dll C:\Windows\System32\mswsock.dll 6.1.7601.18254
wship6.dll  C:\Windows\System32\wship6.dll  6.1.7600.16385
IPHLPAPI.DLL    C:\Windows\System32\IPHLPAPI.DLL    6.1.7601.17514
winnsi.dll  C:\Windows\System32\winnsi.dll  6.1.7600.16385
urlmon.dll  C:\Windows\System32\urlmon.dll  11.0.9600.18212
api-ms-win-downlevel-shlwapi-l2-1-0.dll C:\Windows\System32\api-ms-win-downlevel-shlwapi-l2-1-0.dll 6.2.9200.16492
dnsapi.dll  C:\Windows\System32\dnsapi.dll  6.1.7601.17570
oleaut32.dll    C:\Windows\System32\oleaut32.dll    6.1.7601.18679
WSHTCPIP.DLL    C:\Windows\System32\WSHTCPIP.DLL    6.1.7600.16385
FWPUCLNT.DLL    C:\Windows\System32\FWPUCLNT.DLL    6.1.7601.18283
rasadhlp.dll    C:\Windows\System32\rasadhlp.dll    6.1.7600.16385
comctl32.dll    C:\Windows\winsxs\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_fa3b1e3d17594757\comctl32.dll    6.10.7601.18837
credssp.dll C:\Windows\System32\credssp.dll 6.1.7601.19135
schannel.dll    C:\Windows\System32\schannel.dll    6.1.7601.19135
ncrypt.dll  C:\Windows\System32\ncrypt.dll  6.1.7601.19135
bcrypt.dll  C:\Windows\System32\bcrypt.dll  6.1.7600.16385
bcryptprimitives.dll    C:\Windows\System32\bcryptprimitives.dll    6.1.7601.19012
wintrust.dll    C:\Windows\System32\wintrust.dll    6.1.7601.18839
gpapi.dll   C:\Windows\System32\gpapi.dll   6.1.7600.16385
cryptnet.dll    C:\Windows\System32\cryptnet.dll    6.1.7601.18839
Wldap32.dll C:\Windows\System32\Wldap32.dll 6.1.7601.17514
SensApi.dll C:\Windows\System32\SensApi.dll 6.1.7600.16385
powrprof.dll    C:\Windows\System32\powrprof.dll    6.1.7600.16385
setupapi.dll    C:\Windows\System32\setupapi.dll    6.1.7601.17514
cfgmgr32.dll    C:\Windows\System32\cfgmgr32.dll    6.1.7601.17514
devobj.dll  C:\Windows\System32\devobj.dll  6.1.7600.16385