sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
810 stars 39 forks source link

Status bar incorrect height when using macOS tabs #1639

Closed JulyIghor closed 7 years ago

JulyIghor commented 7 years ago

Summary

Wrong status bar height

Expected behavior

Correct status bar height

Actual behavior

Sometimes status bar height become incorrect size

Steps to reproduce

I do nothing, just use Sublime Text, search/replace hotkeys In a random moment I can see that status bar become 2px height, almost invisible, or sometimes it becomes 2 times higher than expected. Maybe it caused by not standard DPI size in the config, anyway it should be fixed.

Environment

Settings file:

{
    "color_scheme": "Packages/Color Scheme - Default/iPlastic.tmTheme",
    "dpi_scale": 1.5,
    "font_size": 16,
    "highlight_modified_tabs": true,
    "ignored_packages":
    [
        "Vintage"
    ],
    "soda_folder_icons": true,
    "theme": "Soda Light 3.sublime-theme"
}

screenshot 2017-03-31 21 08 44

keith-hall commented 7 years ago

does this happen with the Default theme? does changing the DPI scale to 1.0 in your config stop it from changing size randomly? presumably using the menu for find and replace functionality instead of hotkeys makes no difference?

JulyIghor commented 7 years ago

It happens when I open/close native macOS tabs. Incorrect height becomes fixed once I resize the window in any way. Moving window have no effect.

screenshot 2017-03-31 21 30 40

JulyIghor commented 7 years ago

Any ETA to fix this? Or is there way I can fix it myself?

JulyIghor commented 7 years ago

One more thing. Please never disable native tabs, combining Sublime Text internal tabs with macOS tabs is extremely great feature.

keith-hall commented 7 years ago

Sounds like a MacOS bug whereby it doesn't fire a resized event when opening/closing "native macOS tabs", despite the available client area of the window changing.

wbond commented 7 years ago

Can you confirm if this is still an issue with build 3131?

JulyIghor commented 7 years ago

This is still an issue with build 3131. No changes. PS: Great icon!

JulyIghor commented 7 years ago

The last thing, just to complete issue info. The issue happens with all new windows that joined macOS tabs. If I resize the window, current window status bar becomes fixed until closed. Any next window joined tabs appears with status bar bug.

keith-hall commented 7 years ago

This has been fixed in build 3133