phantom text causes search results to be visually de-selected

sublimehq / sublime_text

Issue tracker for Sublime Text

https://www.sublimetext.com

807 stars 39 forks source link

phantom text causes search results to be visually de-selected #2422

Open indirectlylit opened 6 years ago

indirectlylit commented 6 years ago

Summary

When phantom text is shown after a line is selected due to searching, the search result is visually de-selected. This makes the search result much harder to find on the screen.

Expected behavior

Phantom text should not interfere with existing search result highlighting

Actual behavior

phantom

Steps to reproduce

Install GitGutter with phantom text used to display blame
Search through a file

Environment

GitGutter 1.9.4
OS: Mac OS 10.13
Sublime Text: Build 3.1.1 build 3176

BenjaminSchaaf commented 5 years ago

This seems to be fixed by GitGutter 1.9.5:

Disable line annotation if multiple cursors are visible

Disable line annotation if selection is not empty

FichteFoll commented 5 years ago

Are you sure this isn't just a workaround, @BenjaminSchaaf?

BenjaminSchaaf commented 5 years ago

@FichteFoll Definitely a workaround, sorry if that wasn't clear.