sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
807 stars 39 forks source link

Multiple gutters (for gutter icons) #319

Open simonzack opened 10 years ago

simonzack commented 10 years ago

A lot of sublime text packages use the gutter, which causes gutter icon conflicts, for example the gdb package and the git change-tracking package.

A way to resolve this would be to allow multiple gutters so all the information can be displayed, which can be positioned either on the left or right. This would also improve visibility.

This isn't a new idea, lots of other editors/ides do this (e.g. jetbrains products). Would love to see this implemented.

arvidbjorkstrom commented 10 years ago

This would be a great feature, indeed! :+1:

atomless commented 10 years ago

Please address this! Tagging this with "minor" definitely underestimates it's importance.

FichteFoll commented 10 years ago

@atomless, how is this so important for you in particular?

groug commented 10 years ago

I agree with @atomless on the fact that it's more than "minor": I'm using the gutter with SublimeLinter and Modific (git status of my file). With a one-icon gutter, I can't have both info if there's a code issue on a newly-modified line of a revisioned file. It's not a major issue (for me, anyway: Modific seems to have the priority, and SublimeLinter displays the error/warning in the status bar), but it can really be interesting to at least set the display priority of the plugins that draw stuff in the gutter.

edsadr commented 10 years ago

This should be a must have... really cant see linter errors because gitgutter make them hidden ... it sucks

erwinverdonk commented 9 years ago

Yeah, I would like to up-vote this as well. Same problem as edsadr, I can not use both ESLint and GitGutter as the same time or else I do not see my ESLint warnings/errors.

titoBouzout commented 9 years ago

"minor" as I interpret it is not "just minor", isn't "major" nor "critical"

tomedharris commented 9 years ago

+1 GitGutter overrides Xdebug Breakpoints which means I have to disable the GitGutter and restart ST every time I wish to do some debugging.

yerke commented 9 years ago

+1 I have a problem with XDebug and VCS gutter info.

samatcd commented 9 years ago

+1, I have this issue with GitGutter, SublimeLinter and Xdebug breakpoints. Extremely frustrating not to get that visual feedback, particularly with SublimeLinter (which is why I installed those plugins in the first place).

Although I'd prefer to be able to only have a single gutter, but to be able to set the priority for icons showing in the gutter. E.g., I'd set my priority to Xdebug always, if no Xdebug show SublimeLinter, and if neither of those, show GitGutter.

FichteFoll commented 9 years ago

For a single gutter I suggest a kind of icon that indicates if a line has multiple icons associated with it and then hovering the gutter at that point would show all the icons in a tooltip.

The other option would just be to enlarge the gutter by as much as is needed to display all gutter icons of a line at the same time.

arvidbjorkstrom commented 9 years ago

A nice behaviour, in my opinion, would be:

Building on @samatcd and @FichteFoll's proposals =)

georgebonnr commented 9 years ago

:+1: even if the gutter width was adjustable, to allow icons to stack, that would be great.

emma-sg commented 9 years ago

:+1: @arvidbjorkstrom Sounds good! I'd love to see this implemented.

aaron-cardenas commented 9 years ago

At the very least you should can establish gutter priority!

smeijer commented 9 years ago

+1, with multiple validators (jshint, jscs), gitgutter, and bracket highlighters, the missing icons are getting really frustrating.

JeroenVdb commented 9 years ago

+1

abernix commented 9 years ago

:+1:

jorenmartijn commented 9 years ago

:+1: This would be great! I use SublimeLinter and Color Highlighter and the first one overwrites the later if they both have something on the same line. A use case for me for example is that I'm experimenting with styling and animating SVG icons, so when I use the CSS fill: #fff; attribute, SublimeLinter doesn't see that as a valid attribute since it's for SVG only. This results in the Linter warning overwriting the color code from Highlighter in the gutter.

tobypinder commented 9 years ago

I could see a perhaps easier feature would be if ST assigned each gutter-icon a "priority" (driven by user config). That way I could set, say, my GitGutter entries at a lower priority than anything that might replace them. This would seem like a more user friendly solution as multiple gutters would take up more space.

mnort9 commented 9 years ago

+1

amatiasq commented 9 years ago

+1

olivierGM commented 9 years ago

+1

jfmengels commented 9 years ago

+1

vfhrr commented 9 years ago

+1

tomasyany commented 9 years ago

+1

caladfelipe commented 9 years ago

+1

spandel commented 9 years ago

+1 Using VCS Gutter and SublimeLinter. Both very pleasant packages but VCS Gutter overrides the SublimeLinter icons, so if I change something, I can't see any "linter-help" regarding it.

cbierman commented 9 years ago

+1 Using GitGutters and Xdebug, it becomes frustrating figuring out where your breakpoints are.

DeanBDean commented 9 years ago

+1 Definitely running into frustrating conflicts between XDebug, SublimeLinter and GitGutter

QasimK commented 9 years ago

+1

lesenther commented 9 years ago

:+1:

bl4ckcontact commented 9 years ago

+1

cool-acid commented 9 years ago

+1

ghost commented 9 years ago

Do you guys mean multiple gutters or a wider gutter? I think the gutter should accommodate and get wider/narrower depending on how many gutter plugins we have. No settings, no need to complicate things. Even 6 sequential gutter icons (same as 6 characters) wouldn't make the gutter that large so count me in.

spandel commented 9 years ago

@megadr01d yeah, that's how I would want it too! In my case, just setting a priority on the different plugins would help a lot, but ideally it would be great to widen the gutter and show all icons for a row.

ghost commented 9 years ago

@spandel A priority setting to manually sort them, OK, that would be useful.

amatiasq commented 9 years ago

I was thinking on a array of priorities in the settings file like

{
  gutter_priority: [
    'SublimeLinter', // First priority, in case of conflict show this one
    'GitGutter', // second priority, show it in any conflict except with SublimeLinter
    'XDebug' // etc
  ]
}

So that any package outside that list would be lower priority.

But a bigger gutter will do too.

abernix commented 9 years ago

For smaller monitors, it seems like there should be a 'gutter_max_icons', too.

On Thu, Jul 9, 2015 at 1:10 PM, A. Matías Quezada notifications@github.com wrote:

I was thinking on a array of priorities in the settings file like

{ gutter_priority: [ 'SublimeLinter', 'GitGutter', 'XDebug' ] }

So that any package outside that list would be lower priority.

But a bigger gutter will do too.

— Reply to this email directly or view it on GitHub https://github.com/SublimeTextIssues/Core/issues/319#issuecomment-119898002 .

tobypinder commented 9 years ago

@amatiasq I absolutely would agree here. The real problem that causes problems ("this line changed in git" overwriting "syntax error" etc.) is the lack of gutter priority. Additional or wider gutters, though a welcome option, would be a partial solution to that problem, and would be an option that some people would find subpar. I for one value even the couple of extra characters worth of space I'd lose, and the complete shift in how you "read" it being from vertical only to vertical with a very minor horizontal component would be a little annoying.

spandel commented 9 years ago

@tobypinder as I see it, they both have benefits. I totally agree in all of the points you are making, and maybe they are strong enough to prefer the "priority" option. However I also see that there could be a different value in seeing multiple icons for the same row. For example, A warning or error on a row doesn't necessarily imply that a change has been made for that row since the last commit. I'm sure there are other cases as well, however I am currently only familiar with two gutter plugins.

Personally, I would be happy with either one of them.

aptik commented 9 years ago

+1

hatarist commented 9 years ago

+1

lapause commented 9 years ago

+1

wwjholmes commented 9 years ago

+1 Hope this could be Christmas gift!

Worth commented 9 years ago

+1

andheiberg commented 9 years ago

+1

hsbrighenti commented 9 years ago

+1

ThomasBormans commented 9 years ago

+1

marqpdx commented 9 years ago

+1 GitGutter and BracketHighlighter

i would prefer more than one gutter, rather than prioritizing one Plugin over another. I want both the git icon and the bracket icon, side by side.

thanks! m