Save as dialog is not following OS theme

deadrow commented 3 years ago

Description

Save as dialog is not following OS theme while Open dialog is correct

Steps to reproduce

Start Sublime Text in safe mode
Save a file. This will open save dialog

Expected behavior

Save as dialog should follow OS theme

Actual behavior

Save as dialog is not following OS theme. It is always light-themed.

Environment

Build: 4107
Operating system and version: macOS 10.15.7

deadrow commented 3 years ago

BenjaminSchaaf commented 3 years ago

Unfortunately the save dialog when opened from a window will follow the theme of the window. You're using the default "light" theme and thus the save dialog will use the light theme as well. You can instead configure automatic theme switching (or just use a dark theme) to get a dark save dialog.

strycker commented 3 years ago

Unfortunately the save dialog when opened from a window will follow the theme of the window. You're using the default "light" theme and thus the save dialog will use the light theme as well. You can instead configure automatic theme switching (or just use a dark theme) to get a dark save dialog.

@BenjaminSchaaf , what do you mean by the "theme of the window"? My mac is set up to Dark Mode, and my Sublime Text theme is already set to a dark color scheme (problem persists for theme "Monokai", "Mariana", and plugin "Cobalt2").

I did notice that when I choose "Auto" for my theme, Sublime Text thinks I'm in a light theme and not my mac's dark theme setting. Looks like Sublime Text isn't properly detecting the mac state.

--- later edit ---

Never mind, I see I was setting the color SCHEME, not the THEME. However, note that the Auto setting still thinks it's in light mode. Have to change it to Cobalt2 to get the dark one I want.

BenjaminSchaaf commented 3 years ago

Never mind, I see I was setting the color SCHEME, not the THEME. However, note that the Auto setting still thinks it's in light mode. Have to change it to Cobalt2 to get the dark one I want.

Can you share the settings you're using for auto theme switching? It should be something like the default:

    "theme": "auto",
    "light_theme": "Default.sublime-theme",
    "dark_theme": "Default Dark.sublime-theme",

strycker commented 3 years ago

In Sublime Text/Packages/Default/Preferences.sublime-settings:

"theme": "auto", "light_theme": "Default.sublime-theme", "dark_theme": "Default Dark.sublime-theme",

In Sublime Text/Packages/User/Preferences.sublime-settings:

"theme": "Adaptive.sublime-theme",

nothing set for light_theme, dark_theme

then this:

"color_scheme": "Packages/Theme - Cobalt2/cobalt2.tmTheme", "dark_color_scheme": "Packages/Color Scheme - Default/Celeste.sublime-color-scheme", "light_color_scheme": "Packages/Color Scheme - Default/Celeste.sublime-color-scheme",

BenjaminSchaaf commented 3 years ago

I'm unable to reproduce that on build 4113, which does have some related fixes. Are you still running 4107?

strycker commented 3 years ago

I'm on 4113

BenjaminSchaaf commented 3 years ago

I'm unable to reproduce this. Setting the theme to adaptive and color scheme to cobalt2 always correctly uses the dark themed save-as dialog on macOS 11.4.

deathaxe commented 3 years ago

May it depend on "dark_color_scheme": "Packages/Color Scheme - Default/Celeste.sublime-color-scheme",? Celestre is quite light.

BenjaminSchaaf commented 3 years ago

Starting in safe mode, installing the cobalt2 color scheme and using the following settings:

{
    "color_scheme": "Packages/Theme - Cobalt2/cobalt2.tmTheme",
    "dark_color_scheme": "Packages/Color Scheme - Default/Celeste.sublime-color-scheme",
    "light_color_scheme": "Packages/Color Scheme - Default/Celeste.sublime-color-scheme",
    "theme": "Adaptive.sublime-theme",
    "dark_theme": "Default Dark.sublime-theme",
    "light_theme": "Default.sublime-theme",
}

Still uses a dark theme as expected regardless of what the system is set to.

sublimehq / sublime_text