sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
807 stars 39 forks source link

annotation scrollbar wrong luminosity attribute #4845

Open AmjadHD opened 3 years ago

AmjadHD commented 3 years ago

Description

annotation 0

control tree of the annotation scrollbar thumb (Adaptive theme, with a file_medium_dark color scheme):

control tree at: 1358.5,106.5
title_bar [file_medium_dark] pos: 0,0 size: 1366,728
    .bg=[24, 26, 31, 255]
    .fg=[191, 192, 194, 255]
    .style=dark
 popup_shadow pos: 1274.26,44 size: 106.741,501
     .content_margin=[15, 14, 15, 16]
     .layer0.draw_center=false
     .layer0.inner_margin=[15, 14, 15, 16]
     .layer0.opacity=1
     .layer0.texture=res://Packages/Theme - Default/common/windows_shadow.png
  popup_control annotation_popup pos: 1289.26,58 size: 76.7412,471
      .layer0.opacity=1
   scroll_area_control [scrollable] pos: 1289.26,58 size: 76.7412,471
    scroll_bar_control [file_light] pos: 1351,58 size: 15,471
        .content_margin=[4, 4, 4, 4]
        .layer0.opacity=1
        .tint_index=0
     scroll_track_control [file_light] pos: 1355,62 size: 7,463
         .content_margin=[4, 4, 3, 4]
         .layer0.inner_margin=[2, 2, 2, 2]
         .layer0.opacity=0.1
         .layer0.texture=res://Packages/Theme - Default/common/scroll.png
         .layer0.tint=[0, 0, 0, 255]
      puck_control [file_light] pos: 1355,62 size: 7,403.839
          .content_margin=[0, 12, 0, 12]
          .layer0.inner_margin=[2, 2, 2, 2]
          .layer0.opacity=0.6
          .layer0.texture=res://Packages/Theme - Default/common/scroll.png
          .layer0.tint=[0, 0, 0, 255]
 edit_window window [file_medium_dark] pos: 0,23 size: 1366,705
  grid_layout_control pos: 0,23 size: 1366,505
      .border_color=[24, 26, 31, 255]
      .border_size=2
   pane_container_control pos: 0,23 size: 1366,505
    sheet_container_control pos: 0,57 size: 1366,471
        .layer0.opacity=1
     scroll_area_control [scrollable] pos: 0,57 size: 1366,471
      scroll_bar_control [dark, file_medium_dark] pos: 1351,57 size: 15,471
          .content_margin=[4, 4, 4, 4]
          .layer0.opacity=1
          .tint_index=0
       scroll_track_control [dark, file_medium_dark] pos: 1355,61 size: 7,463
           .content_margin=[4, 4, 3, 4]
           .layer0.inner_margin=[2, 2, 2, 2]
           .layer0.opacity=0.1
           .layer0.texture=res://Packages/Theme - Default/common/scroll.png
        puck_control [dark, file_medium_dark] pos: 1355,61 size: 7,168.918
            .content_margin=[0, 12, 0, 12]
            .layer0.inner_margin=[2, 2, 2, 2]
            .layer0.opacity=0.2
            .layer0.texture=res://Packages/Theme - Default/common/scroll.png

Steps to reproduce

  1. start Sublime Text in safe mode, the color scheme set is Mariana (not light)
  2. run view.add_regions("foo", [sublime.Region(0, 0)], annotations=["<div>bar</div>" * 30])
  3. hover the annotation

Expected behavior

A dark scrollbar

Actual behavior

A light scrollbar

Environment

AmjadHD commented 3 years ago

It looks like the luminosity attribute is hardcoded, it's file_light regardless of the color scheme.

AmjadHD commented 3 years ago

I upgraded Windows from 1803 (2018) to 20H2, and it was fixed.

AmjadHD commented 2 years ago

Actually it wasn't.