sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
801 stars 36 forks source link

Closing Sublime Text does not preserve open files #5011

Open amollad opened 2 years ago

amollad commented 2 years ago

Description of the bug

This I am finding in Build 4121. I've many files opened in Sublime Text and if I close Sublime Text using File -> Exit and the restart Sublime Text - I see all my open files again. However, if I close Sublime Text using Windows "x" close button on top right of the window and then open Sublime Text - it all starts from fresh and I need to add folders again.

I do not recall seeing this behavior in older builds

Steps to reproduce

  1. Start Sublime Text
  2. File -> Open Folder
  3. Close Sublime Text using "x" button on top right of the window
  4. Open Sublime Text - the folder opened in [2] is no more available and we need to add again

Expected behavior

After [4] above, we should see the folder(s) added in [2] above

Actual behavior

All open folders are lost on exit using windows "x" button on top right

Sublime Text build number

4121

Operating system & version

Windows

(Linux) Desktop environment and/or window manager

No response

Additional information

No response

OpenGL context information

No response

BenjaminSchaaf commented 2 years ago

Do you have another window open, perhaps on another desktop? A hot exit is only done when the application exits, be it from File > Exit or by closing the last open window. This has always been the case.

amollad commented 2 years ago

Thanks. Please refer to this video for what I'm trying to explain:

https://youtu.be/kfIyQCVx4Ww

On Fri, 5 Nov 2021 at 10:21, Benjamin Schaaf @.***> wrote:

Do you have another window open, perhaps on another desktop? A hot exit is only done when the application exits, be it from File > Exit or by closing the last open window. This has always been the case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sublimehq/sublime_text/issues/5011#issuecomment-961626206, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHBOYIVFL6Z5J64IG5XNXTUKNPF3ANCNFSM5HNAIR6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BenjaminSchaaf commented 2 years ago

That's definitely not expected behavior. After exiting ST could you upload what's in the session file? It's located here: %APPDATA%\Sublime Text\Local\Session.sublime_session or %APPDATA%\Sublime Text 3\Local\Session.sublime_session.

amollad commented 2 years ago

Please find it here: https://drive.google.com/file/d/18ChGj5QBxynn_ZUtL-I_bZ7QCVQoAnP-/view?usp=sharing

This file is generated after ST is exited using windows "x" button and (and starting ST again does not open last opened folders/files)

On Fri, 5 Nov 2021 at 11:54, Benjamin Schaaf @.***> wrote:

That's definitely not expected behavior. After exiting ST could you upload what's in the session file? It's located here: %APPDATA%\Sublime Text\Local\Session.sublime_session or %APPDATA%\Sublime Text 3\Local\Session.sublime_session.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sublimehq/sublime_text/issues/5011#issuecomment-961655164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHBOYMSESL4RWMXDEUDKI3UKN2DDANCNFSM5HNAIR6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BenjaminSchaaf commented 2 years ago

Thanks. Looks like it's only saving the open folder, but not the unsaved file. Can you share the settings you're using?

amollad commented 2 years ago

Is there a way I can easily share settings using say XML or txt files?

On Fri, 5 Nov 2021 at 12:15, Benjamin Schaaf @.***> wrote:

Thanks. Looks like it's only saving the open folder, but not the unsaved file. Can you share the settings you're using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sublimehq/sublime_text/issues/5011#issuecomment-961662252, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHBOYLZBOFWC5JIP5Z6X23UKN4RVANCNFSM5HNAIR6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BenjaminSchaaf commented 2 years ago

Simply open settings from Preferences > Settings and copy the json from the right hand side.

amollad commented 2 years ago

{ "font_size": 17 }

On Fri, 5 Nov 2021 at 12:19, Benjamin Schaaf @.***> wrote:

Simply open settings from Preferences > Settings and copy the json from the right hand side.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sublimehq/sublime_text/issues/5011#issuecomment-961663696, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHBOYOUQCNO4IPX3YYP57DUKN5AZANCNFSM5HNAIR6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BenjaminSchaaf commented 2 years ago

Thanks. Could you post the full logs from the console (View > Show Console) after startup?

amollad commented 2 years ago

DPI mode: per-monitor v2 startup, version: 4121 windows x64 channel: stable executable: /C/Program Files/Sublime Text 3/sublime_text.exe application: /C/Program Files/Sublime Text 3 working dir: /C/Program Files/Sublime Text 3 packages path: /C/Users/Amol.Lad/AppData/Roaming/Sublime Text 3/Packages state path: /C/Users/Amol.Lad/AppData/Roaming/Sublime Text 3/Local zip path: /C/Program Files/Sublime Text 3/Packages zip path: /C/Users/Amol.Lad/AppData/Roaming/Sublime Text 3/Installed Packages ignored_packages: ["Vintage"] pre session restore time: 0.119696 startup time: 0.203696 first paint time: 0.203696 reloading plugin Default.arithmetic reloading plugin Default.auto_indent_tag reloading plugin Default.block reloading plugin Default.colors reloading plugin Default.comment reloading plugin Default.convert_color_scheme reloading plugin Default.convert_syntax reloading plugin Default.copy_path reloading plugin Default.echo reloading plugin Default.exec reloading plugin Default.fold reloading plugin Default.font reloading plugin Default.goto_line reloading plugin Default.history_list reloading plugin Default.html_print reloading plugin Default.indentation reloading plugin Default.install_package_control reloading plugin Default.keymap reloading plugin Default.kill_ring reloading plugin Default.mark reloading plugin Default.new_templates reloading plugin Default.open_context_url reloading plugin Default.open_in_browser reloading plugin Default.pane reloading plugin Default.paragraph reloading plugin Default.paste_from_history reloading plugin Default.profile reloading plugin Default.quick_panel reloading plugin Default.rename reloading plugin Default.run_syntax_tests reloading plugin Default.save_on_focus_lost reloading plugin Default.scroll reloading plugin Default.set_unsaved_view_name reloading plugin Default.settings reloading plugin Default.show_scope_name reloading plugin Default.side_bar reloading plugin Default.sort reloading plugin Default.switch_file reloading plugin Default.symbol reloading plugin Default.transform reloading plugin Default.transpose reloading plugin Default.ui reloading plugin CSS.css_completions reloading plugin Diff.diff reloading plugin HTML.encode_html_entities reloading plugin HTML.html_completions reloading plugin ShellScript.ShellScript plugins loaded

BenjaminSchaaf commented 2 years ago

That all looks expected. It seems to be the only possible cause would be ST crashing before exiting. You can confirm this by waiting more than 30s before exiting ST, after which the opened files should be preserved from the automatic session saving.