sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
807 stars 39 forks source link

Sublime Text 3 shows "unknown" version in winget after installation #5272

Open ali50m opened 2 years ago

ali50m commented 2 years ago

Description of the bug

After installing Sublime Text 3 which is downloaded from https://download.sublimetext.com/Sublime%20Text%20Build%203211%20Setup.exe,

when run following command in my Windows Terminal, it will show the version of Sublime Text 3 is unknown.

winget upgrade

There is also someone reported similiar Sublime text 4 issue in microsoft/winget-pkgs, Sublime Text 4 shows "unknown" version after installation.

Could you guys please take a look at the suggestion from Msft? thanks~ (from a huge fan, both of SublimeText and winget)

image

Steps to reproduce

  1. download sublime text 3, and install it.
  2. try to upgrade softwares in winget by the following commands.
    
    winget upgrade


### Expected behavior

show the correct version of sublime text.

### Actual behavior

the version shows as "unknown", if I try to upgrade sublime text 3 from winget (even I have installed the latest version), the sublime text 3 will be downloaded and installed again from winget. But the version will be still the same and shown "unkonwn" in winget.

### Sublime Text build number

3211

### Operating system & version

Windows 10

### (Linux) Desktop environment and/or window manager

_No response_

### Additional information

someone has reported similar issue microsoft/winget-pkgs#37597 , and someone has pointed how to **fix** it <https://github.com/microsoft/winget-pkgs/issues/37597#issuecomment-992674355>.

### OpenGL context information

_No response_
UltraInstinct05 commented 2 years ago

Does the same thing happen with Sublime Text 4 as well ? ST3 will probably never receive any updates so all that matters is the latest stable build of ST4

keith-hall commented 2 years ago

Possible duplicate of https://github.com/sublimehq/sublime_text/issues/1114

ali50m commented 2 years ago

Does the same thing happen with Sublime Text 4 as well ? ST3 will probably never receive any updates so all that matters is the latest stable build of ST4

I just tested in my PC. It`s seem ST4 could be another issue in winget.

image

ali50m commented 2 years ago

My mistake for closing this issue accidently.

I haven`t seen this kind of version issue with other SWs installed with winget (more than 150 softwares installed). Hope ST3 can fix this annoying version displaying issue. thanks!

jmelas commented 2 years ago

It seems the installers are done using InnoSetup.

So the solution is simply to add this entry to the iss file:

[Setup] AppVersion=current version string

Thank you very much for considering this!