sublimehq / sublime_text

Issue tracker for Sublime Text
https://www.sublimetext.com
803 stars 39 forks source link

Implement freedesktop color scheme preference (New Dark theme setting standard) #5350

Open colinkiama opened 2 years ago

colinkiama commented 2 years ago

Problem description

There are some Linux distributions right now like elementary OS that are strictly sticking to the standard so Sublime Text is always showing the light color scheme on there.

The old method of determining to show the dark theme based on the GTK Theme has stopped working and may no longer work for more distributions in the future as this standard has been implemented already in both GNOME and KDE.

Preferred solution

Implement the freedesktop color scheme preference: https://github.com/flatpak/xdg-desktop-portal/blob/d7a304a00697d7d608821253cd013f3b97ac0fb6/data/org.freedesktop.impl.portal.Settings.xml#L33-L45

Alternatives

The current way of doing things (using GTK Theme) may be useful to keep for figuring out whether to use dark theme or not in older distributions but won't be adopted for some distributions like "elementary OS" as stated above.

Additional Information

https://bugzilla.mozilla.org/show_bug.cgi?id=1734934 https://github.com/flatpak/xdg-desktop-portal/pull/633 https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/12 https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/

jnns commented 1 year ago

This affects both Sublime Text and Sublime Merge on recent versions of Gnome, KDE and possibly other environments that I don't know about.

Could you prioritize this issue for one of the next releases? 🙏🏻 It has been an issue for more than a year already.

wout commented 1 year ago

I can confirm this is still broken in both Sublime Text and Sublime Merge. Almost all the other apps I use follow the system's theme as expected. I'm on elementary OS 7.

auto-light

auto-dark