native macOS tabs broken with Adaptive theme

jrappen commented 1 year ago

Description of the bug

Sublime Text does not open settings (or the changelog or two folders by running subl subfolder1 && subl subfolder2) by default in native macOS tabs when using the "Adaptive.sublime-theme".

It does however when using Default themes (i.e. using "auto" or "Default.sublime-theme" or "Default Dark.sublime-theme").

Steps to reproduce

Start in safe-mode.
Open settings.
- "theme": "auto" is default
- native tabs work as expected
Set "theme": "Adaptive.sublime-theme".
Close settings.
Open settings.
- native tabs are now broken
- new stuff does not open in a native tab within the same window but in a new separate window

Same with changelog etc. etc.

Expected behavior

Settings are opened side-by-side in a new native macOS tab within the same window.

Actual behavior

Settings are opened side-by-side in a new window.

Sublime Text build number

4147

Operating system & version

macOS Ventura 13.2.1 (22D68)

Additional information

Sublime_Text:
  build: 4147
  channel: dev
  platform: osx x64
    portable: false
  pre_session_restore_time: 0.2957
  startup_time: 0.3804
  first_paint_time: 0.5071
  env_vars: '/bin/zsh -l'

System:
  hardware: >-
    MBP 15inch 2018,
    2.9 GHz 6-Core Intel Core i9-8950HK @ 2.90 GHz,
    32GB 2400 MHz DDR4,
    1TB,
    Radeon Pro 560X
  software:
    - macos_ver: macOS Ventura 13.2.1 (22D68)
      kernel_version: Darwin 22.3.0
      open_gl:
        gl_api_version: 4.1 INTEL-20.2.50
        glsl_version: 4.10
        vendor: Intel Inc.
        renderer: Intel(R) UHD Graphics 630, 1536 MB

OpenGL context information

gl_api_version: 4.1 INTEL-20.2.50
glsl_version: 4.10
vendor: Intel Inc.
renderer: Intel(R) UHD Graphics 630, 1536 MB

Note

Temp workaround for affected users: Use "auto" instead. Not adaptive, but gives you auto light/dark.

jrappen commented 1 year ago

This is:

a https://github.com/sublimehq/sublime_text/labels/T%3A%20regression
likely related to #5329

jrappen commented 8 months ago

Behavior slightly changes with native tabs already open when switching to adaptive theme:

title bar and native tabs have default theme styling
side bar, tabs, sheets and status bar have adaptive theme styling
as soon as there's only one native tab left (i.e. no native tabs shown), adding a native tab will open new windows instead of new native tabs again as described above

sublimehq / sublime_text