NPM version or script - Githubissues

sublimelsp / LSP-css

CSS, SCSS, LESS support for Sublime's LSP plugin

MIT License

37 stars 0 forks source link

NPM version or script #18

Closed predragnikolic closed 4 years ago

predragnikolic commented 4 years ago

Should we use the npm version - https://www.npmjs.com/package/vscode-css-languageservice?activeTab=dependents

pros: dependabot creates PRs when new releases are available
cons: can't guarantee that the npm package will be maintained

or script for updating this repo

pros: ability to have latest changes
cons: maybe forget to run the script until someone mentions you to run it :)

I seriously don't know what approach is better :)

rchl commented 4 years ago

Using npm package is better unless there is something wrong with the npm package or it's outdated.

I'm not sure why we've switched to building manually. It was done in #2. The most likely reason is that the npm package was outdated but it seems to be up to date now.

jfcherng commented 4 years ago

+1 for packages on NPM + dependabot. But, note that the NPM package proposed by @predragnikolic is different from what we are using now, which depends on that NPM package.

Does vscode-css-language"service" work for us? I mean, is it a LSP server? How to run it in ST? In that case, there is no point someone extracts https://github.com/vscode-langservers/vscode-css-languageserver.

rchl commented 4 years ago

But, note that the NPM package proposed by @predragnikolic is different from what we are using now, which depends on that NPM package.

Oh, yes. The "service" one is what the "server" is using. We can't use "*service" directly.

The one we could use is released as https://www.npmjs.com/package/vscode-css-languageserver-bin but that one is outdated.

So that's why we are building manually.

predragnikolic commented 4 years ago

Yes, now it makes sense, thanks for the clarification. 🙂