search

sublimelsp / LSP-eslint

ESLint support for Sublime LSP plugin
MIT License
34 stars 5 forks source link

Support ESLint 9 flat config #72

Closed predragnikolic closed 2 weeks ago

predragnikolic commented 4 weeks ago

closes #68

predragnikolic commented 4 weeks ago

There are 2 small things: (non of them I see as blockers)

  1. https://github.com/microsoft/vscode-eslint/issues/1885

The default for useFlatConfig is null, but the type in the schema is a boolean. This point isn't that import, because we do not specify this setting. The server will be able to understand flat configs, as long as someone has ESLint version higher than 8.57.0 (v9.x.x and above). See https://github.com/microsoft/vscode-eslint/pull/1882/files

  1. https://github.com/microsoft/vscode-eslint/issues/1886

While working on this PR, I wanted to remove the eslint.experimental.useFlatConfig https://github.com/sublimelsp/LSP-eslint/blob/1e61688de754f48664e156a42f1ceee4a11b5b1a/LSP-eslint.sublime-settings#L21 but doing that will cause the server to throw errors like Cannot read properties of undefined (reading 'useFlatConfig') so I decided to keep the eslint.experimental.useFlatConfig setting for now.

I've opened an issue(question) just to see what their answer is.