sublimelsp / LSP-gopls

Golang support for Sublime's LSP plugin
MIT License
47 stars 8 forks source link

Vuln Check response is broken #44

Open TerminalFi opened 1 year ago

TerminalFi commented 1 year ago

Previously, running Vuln check would return the response. It now returns tokens and we must fetch the response.

rwols commented 1 year ago

Was this fixed somehow?

TerminalFi commented 1 year ago

Was this fixed somehow?

Mmm this is working for me currently. Let me ensure I don’t have. Local changes.

TerminalFi commented 1 year ago

Gopls now sends a response containing a Token

The Token will eventually return the response.

TerminalFi commented 1 year ago

The logs look like

:: [08:56:29.716] --> gopls workspace/executeCommand (23): {'arguments': [{'uri': 'file:///Users/terminal/git/livesession/...'}], 'command': 'gopls.run_govulncheck'}
:: [08:56:29.718] <-- gopls window/workDoneProgress/create (9): {'token': '5109677722660650344'}
:: [08:56:29.718] >>> gopls (9) (duration: 0ms): None
:: [08:56:29.718] <-  gopls $/progress: {'token': '5109677722660650344', 'value': {'title': 'govulncheck', 'cancellable': True, 'kind': 'begin', 'message': 'Running...'}}
:: [08:56:29.719] <<< gopls (23) (duration: 3ms): {'Token': '5109677722660650344'}
gopls: 2023/06/12 08:56:29 08:56:29 Loading packages...

    operation="vulncheck"

:: [08:56:29.743] <-  gopls $/progress: {'token': '5109677722660650344', 'value': {'cancellable': True, 'kind': 'report', 'message': '08:56:29 Loading packages...'}}
:: [08:56:29.743] <-  gopls window/logMessage: {'type': 3, 'message': '2023/06/12 08:56:29 08:56:29 Loading packages...\n\n\toperation="vulncheck"\n'}
gopls: 2023/06/12 08:56:30 08:56:30 Loaded 1 packages and their dependencies

    operation="vulncheck"

:: [08:56:30.206] <-  gopls $/progress: {'token': '5109677722660650344', 'value': {'cancellable': True, 'kind': 'report', 'message': '08:56:30 Loaded 1 packages and their dependencies'}}
:: [08:56:30.206] <-  gopls window/logMessage: {'type': 3, 'message': '2023/06/12 08:56:30 08:56:30 Loaded 1 packages and their dependencies\n\n\toperation="vulncheck"\n'}
gopls: 2023/06/12 08:56:30 08:56:30 Found 0 affecting vulns and 0 unaffecting vulns in imported packages

    operation="vulncheck"

:: [08:56:30.219] <-  gopls $/progress: {'token': '5109677722660650344', 'value': {'cancellable': True, 'kind': 'report', 'message': '08:56:30 Found 0 affecting vulns and 0 unaffecting vulns in imported packages'}}
:: [08:56:30.219] <-  gopls window/logMessage: {'type': 3, 'message': '2023/06/12 08:56:30 08:56:30 Found 0 affecting vulns and 0 unaffecting vulns in imported packages\n\n\toperation="vulncheck"\n'}
gopls: 2023/06/12 08:56:30 tidy: diagnosing file:///Users/terminal/git/livesession/go.mod: err: exit status 1: stderr: go: downloading github.com/onsi/ginkgo v1.6.0
go: downloading github.com/onsi/gomega v1.5.0
go: finding module for package gitlab.com/theseceng/collaborator/node
gitlab.com/theseceng/collaborator/redis imports
    gitlab.com/theseceng/collaborator/node: cannot find module providing package gitlab.com/theseceng/collaborator/node: module lookup disabled by GOPROXY=off
gitlab.com/theseceng/collaborator/client imports
    github.com/go-redis/redis tested by
    github.com/go-redis/redis.test imports
    github.com/onsi/ginkgo: module lookup disabled by GOPROXY=off
gitlab.com/theseceng/collaborator/client imports
    github.com/go-redis/redis tested by
    github.com/go-redis/redis.test imports
    github.com/onsi/gomega: module lookup disabled by GOPROXY=off

:: [08:56:30.482] <-  gopls window/logMessage: {'type': 1, 'message': '2023/06/12 08:56:30 tidy: diagnosing file:///Users/terminal/git/livesession/go.mod: err: exit status 1: stderr: go: downloading github.com/onsi/ginkgo v1.6.0\ngo: downloading github.com/onsi/gomega v1.5.0\ngo: finding module for package gitlab.com/theseceng/collaborator/node\ngitlab.com/theseceng/collaborator/redis imports\n\tgitlab.com/theseceng/collaborator/node: cannot find module providing package gitlab.com/theseceng/collaborator/node: module lookup disabled by GOPROXY=off\ngitlab.com/theseceng/collaborator/client imports\n\tgithub.com/go-redis/redis tested by\n\tgithub.com/go-redis/redis.test imports\n\tgithub.com/onsi/ginkgo: module lookup disabled by GOPROXY=off\ngitlab.com/theseceng/collaborator/client imports\n\tgithub.com/go-redis/redis tested by\n\tgithub.com/go-redis/redis.test imports\n\tgithub.com/onsi/gomega: module lookup disabled by GOPROXY=off\n\n'}
:: [08:56:30.485] <-  gopls window/showMessage: {'type': 3, 'message': 'No vulnerabilities found'}