search

sublimelsp / LSP-json

Schema validation/completions for your JSON and Sublime files
MIT License
72 stars 9 forks source link

The latest LSP-json doesn't work on ST 3. #173

Closed jfcherng closed 9 months ago

jfcherng commented 9 months ago

As per report on https://github.com/sublimelsp/LSP-css/issues/46#issuecomment-1826738397

  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 125, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 1199, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "/Users/juliangarnier/Library/Application Support/Sublime Text 3/Installed Packages/LSP-json.sublime-package/commands.py", line 1, in <module>
ImportError: cannot import name LspTextCommand
juliangarnier commented 9 months ago

I haven't pinpointed which version of lsp-json breaks ST3 compatibility, but the error mentioned above is similar to these issues:

https://github.com/sublimelsp/LSP-html/issues/45 https://github.com/sublimelsp/LSP-css/issues/46

Where both html / css languages introduced a similar change before breaking ST3 compatibility :

Hope this helps, thanks!

rchl commented 9 months ago

Addressed. ST3 is now served an older version of LSP-json that doesn't have ST4-specific code.