search

sublimelsp / LSP-json

Schema validation/completions for your JSON and Sublime files
MIT License
75 stars 10 forks source link

colors: recognize things like `rgba(29, 0, 26, 1)` #59

Closed rwols closed 1 year ago

rwols commented 4 years ago

In a lot of color schemes the colors are defined with things like rgba(...) notation. Can we get this server to recognize those colors?

image

rchl commented 4 years ago

It only supports hex since this is what VSCode supports only and that's all they needed.

I believe this part is relevant: https://github.com/microsoft/vscode-json-languageservice/blob/5e62091ee8e84d898a9440b05540dbe9f07e86c8/src/services/jsonDocumentSymbols.ts#L233

And their tests for this functionality also only test hex: https://github.com/microsoft/vscode-json-languageservice/blob/5e62091ee8e84d898a9440b05540dbe9f07e86c8/src/test/documentSymbols.test.ts#L270-L297

rwols commented 4 years ago

Just a note that the relevant code for parsing those expressions is present in vscode-css-language-server

image
predragnikolic commented 1 year ago

rwols created an issue here so I would suggest subscribing to the issue if you are interested in this feature.

There is nothing that we can do in this repo about this, so I will close this ticket.