search

sublimelsp / LSP-julia

Julia support for Sublime's LSP plugin using LanguageServer.jl
MIT License
23 stars 1 forks source link

Using Julia 1.11 breaks the plugin. #32

Open ghyatzo opened 1 month ago

ghyatzo commented 1 month ago

Hello,

There seems to be an issue with the precompilation of the language server upon launching when using julia 1.11. It complains that the REPL package needs the new StyledString package, which is not on the manifest. Had to manually instantiate the environment for it to work.

Not really sure how you usually deal with the language server environment bumps so didn't took initiatives

jwortmann commented 1 month ago

I see. It works after running resolve for the environment in Julia 1.11, but it seems that StyledStrings has Julia 1.11 as a requirement https://github.com/JuliaLang/StyledStrings.jl/blob/729f56cb7c7064687a19ed02990a532606d83e4c/Project.toml#L7, so I think that it would break backwards compatibility with earlier Julia versions. I'm not sure what would be the best solution for this. It would probably work to create a separate Manifest-v1.11.toml (https://julialang.org/blog/2024/10/julia-1.11-highlights/#manifest_versioning), but this looks annoying to maintain in the future with more Manifest-v1.12.toml etc., and I would need to update them individually and on their respective Julia versions when updating the language server.

I would also like to update LanguageServer.jl, but I can't because the master version has some breaking bugs https://github.com/julia-vscode/LanguageServer.jl/issues/1323 and https://github.com/julia-vscode/LanguageServer.jl/pull/1319. It seems that LanguageServer.jl is completely unmaintained at the moment.

jwortmann commented 1 month ago

I think https://github.com/sublimelsp/LSP-julia/commit/e3b3ed62dd6377e82b6f9b75efda6c93a5a57c43 should fix it for now.

I'll make a new release and see how it goes :innocent:

ghyatzo commented 1 month ago

Thanks a lot for the quick response!

I see LanguageServer is managed by davidanthoff. He also manages juliaup, and PR there are also left to die a slow death. he's also in the VSCode plugin. There should be way more people around julia tooling than 1. but oh well. we can only wait and see.