search

sublimelsp / LSP-lua

Convenience package with a lua language server bundled
MIT License
24 stars 5 forks source link

Hardcoded version #13

Closed rchl closed 4 years ago

rchl commented 4 years ago

I don't fully understand everything that is happening but hardcoded version here seems a bit suspicious: https://github.com/sublimelsp/LSP-lua/blob/19c22a3d24fe847c51ecd65e7e56a3a59145f8fb/.github/workflows/notify-repository-on-published-release.yml#L20

Is it basically ignored on the other end?

rwols commented 4 years ago

Made the appropriate changes to pass along the event payload: https://github.com/sublimelsp/LSP-lua/commit/4abbd6fa2cd8cd8b39f0a851136dcb045ded14a9

See also: https://github.com/sublimelsp/repository/pull/11