search

sublimelsp / LSP-lua

Convenience package with a lua language server bundled
MIT License
24 stars 5 forks source link

feat: add Apple M1 (osx-arm64) support #28

Closed jfcherng closed 2 years ago

jfcherng commented 2 years ago

Resolves https://github.com/sublimelsp/LSP-lua/issues/27 Resolves https://discord.com/channels/280102180189634562/645268178397560865/927245849757646918

Someone has to add osx-arm64 to the platforms in https://github.com/sublimelsp/repository/blob/d54c4fd3aa2ca23e5e7803c538ed5921e5674e0f/repository.json#L447-L460? It seems to be auto generated somehow.

rchl commented 2 years ago

Are you sure that osx-arm64 is supported by PC? I seem to recall that it wasn't.

jfcherng commented 2 years ago

Are you sure that osx-arm64 is supported by PC? I seem to recall that it wasn't.

Hmm... I have no idea about this. There is another solution. Since we now support all ST 4 platform/arch, we can just remove the platforms constraint.

It looks like PC just use the platform-arch format in platforms. So I assume it just works. https://github.com/wbond/package_control/blob/3aa0f04521380ee0776e7d80e7267c7c5c38013e/package_control/providers/release_selector.py#L25-L29

Though at the same time, no one gives comments on https://github.com/wbond/package_control_channel/pull/8361

rchl commented 2 years ago

Though at the same time, no one gives comments on wbond/package_control_channel#8361

I suppose I was thinking about that.