add LSP-rome

[rchl]

TODO

• [x] Lookup rome binary in the workspace
• [x] Update schema with some extra snippets
• [x] Update Readme with more info

[predragnikolic]

notes:

• it would be good if we have json schema support in rome.json files. The schema should ideally exist here... but that is not the case. For the time being users could specify "$schema": "./node_modules/rome/configuration_schema.json", as mentioned in their docs.
  • Add source.organizeImports.rome code action on save. The code action works in VS Code, but not in ST.

1. rome.json options not respected.

I have the following index.js file:

function x() {
let d = 21;
}

I have the following rome.json file:

{
  "$schema": "./node_modules/rome/configuration_schema.json",
  "formatter": {
    "enabled": true,
    "formatWithErrors": false,
    "indentStyle": "space",
    "indentSize": 2,
    "lineWidth": 80,
    "ignore": []
  }
}

When i run format file, this request is send:

:: --> LSP-rome textDocument/formatting(68): {'workDoneToken': 'wd68', 'options': {'trimTrailingWhitespace': True, 'insertFinalNewline': False, 'tabSize': 4, 'trimFinalNewlines': False, 'insertSpaces': False}, 'textDocument': {'uri': 'file:///home/predragnikolic/Documents/sandbox/rome/index.js'}}
:: <<< LSP-rome 68: [{'range': {'start': {'character': 0, 'line': 0}, 'end': {'character': 0, 'line': 5}}, 'newText': 'function x() {\n\tlet d = 21;\n}\n'}]

and the file gets formatted with tabs although I specified spaces. the file uses tab size 4, although I specified 2. So the file gets formatted like this:

function x() {
    let d = 21;
}

But I expect this:

function x() {
  let d = 21;
}

2, At some point Rome shows an error for a valid file...

This looks like a server issue. I don't know how I managed to trigger it. I guess there is nothing we could do about it, except being aware that it can happen. EDIT: you already opened an issue rome/tools#4094 :)

[rchl]

it would be good if we have json schema support in rome.json files.

It's already present in sublime-package.json.

Add source.organizeImports.rome code action on save.

Probably because server doesn't advertise support for it. We should investigate whether we should report this in Rome or whether we should align our LSP logic.

1. rome.json options not respected.

Will check it after adding support for using workspace server.

2, At some point Rome shows an error for a valid file...

Yep, already reported.

[predragnikolic]

It's already present in sublime-package.json.

Ok, it works. I don't know what happened today. It seemed like it didn't work.

[predragnikolic]

The server relies on format on save. If I enable format on save in LSP for ST, it will enable it for all servers, which is not what I would want.

I really wish that they went with code actions on save instead of format on save.

[rchl]

I can't reproduce "1". My rome.json is at the root of the workspace folder.

[rchl]

I've seen on their Discord channel that the project might be in a bit of a trouble financially and a couple of developers left due to that. Might not have a bright future.

[thomasjiangcy]

Thanks for the work! Any chance this will be merged/released any time soon?

[rchl]

I can merge it.

I've noticed that the server might randomly quit because of what I think are some issues in flushing the stdout output. But it's something that would have to be reported to Rome if it keeps happening.

[rchl]

I've added LSP-rome: Organize Imports command to Command Palette. Server doesn't advertise support for the source.organizeImports.rome code action but it's possible to invoke it as long as it's enabled in rome.json.

Also changed default value of rome.requireConfiguration to true to match VSCode extension and because otherwise it reports a lot of issues in projects that don't really expect rome checks.

Also updated to latest version of the server - 12.1.3