Set globalSettings instead of "workspace" settings

sublimelsp / LSP-ruff

LSP helper for ruff - an extremely fast Python linter, written in Rust.

https://packagecontrol.io/packages/LSP-ruff

MIT License

26 stars 4 forks source link

Closed rchl closed 1 year ago

rchl commented 1 year ago

Looks like we should not be setting default options explicitly as then those will override globalSettings. See rust-lsp code here: https://github.com/charliermarsh/ruff-lsp/blob/8474ad1092843ffbf4e6d4d3f030588ab902a060/ruff_lsp/server.py#L724-L730

Fixes issue mentioned in #18

LDAP commented 1 year ago

Should we set global settings instead?

rchl commented 1 year ago

I've looked at the source and it appears that this should be fine.